Merge pull request #13 from ulsdevteam/php8fix

Made function declarations consistent with parents
ulsdevteam · Mar 2, 2023 · 50c47d8 · 50c47d8
2 parents c79dca2 + a857e32
commit 50c47d8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/PlumAnalyticsSettingsForm.inc.php b/PlumAnalyticsSettingsForm.inc.php
@@ -89,7 +89,7 @@ function readInputData() {
 	 * Fetch the form.
 	 * @copydoc Form::fetch()
 	 */
-	function fetch($request) {
+	function fetch($request, $template = NULL, $display = false) {
 		$templateMgr = TemplateManager::getManager($request);
 		$templateMgr->assign('pluginName', $this->_plugin->getName());
 		// This assigns select options
@@ -103,13 +103,13 @@ function fetch($request) {
 			$hideSettings[$k] = array_diff($this->settingsKeys, array_merge($this->_plugin->settingsByWidgetType[$k], $this->_plugin->settingsByWidgetType['_all']));
 		}
 		$templateMgr->assign('plumWidgetHideSettings', $hideSettings);
-		return parent::fetch($request);
+		return parent::fetch($request, $template = NULL, $display = false);
 	}
 
 	/**
 	 * Save settings.
 	 */
-	function execute() {
+	function execute(...$functionArgs) {
 		$plugin =& $this->_plugin;
 		$contextId = $this->_contextId;
 

diff --git a/version.xml b/version.xml
@@ -12,8 +12,8 @@
 <version>
 	<application>plumAnalytics</application>
 	<type>plugins.generic</type>
-	<release>1.4.0.0</release>
-	<date>2020-04-30</date>
+	<release>1.4.0.1</release>
+	<date>2023-02-28</date>
 	<lazy-load>1</lazy-load>
 	<class>PlumAnalyticsPlugin</class>
 </version>