WIP: Tiled tiff loader #350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I change the PR status into WIP, because I'd like to discuss the bigger picture:
|
|
WIP status makes sense. |
move implementation of stuff declared in multi_impex.hxx into multi_impex.cxx (was in imageinfo.cxx) (manually cherry-picked from 2011 improved_tiff_loader branch)
- added TIFFFile::pixelType() - added TIFFFile::readTile() (very thin wrapper around libtiff) - added VolumeInfo::fileType of „TILEDTIFF“ - FIXME: only works with correct target datatype - FIXME: does not cope with multi-channel data yet
hmeine
force-pushed
the
tiled_tiff_loader
branch
from
56f78c0 to
55bdf52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ulli just asked about this stale branch. (I picked up work from 2011 and made it work again, but that was already nearly a year ago.) The big picture of this branch is described in detail(!) in issue #33.
Let's use this PR to discuss what needs to be done to include this (after releasing 1.11.0).
If I remember correctly, I was not fully happy with this yet, but one of the reasons might just have been that the z resolution (which is most likely to differ from x/y) is not present in our TIFFs at all (since they're always accompanied by a DICOM file together with all the medical information). But that should not block inclusion of tiled TIFF reading in VIGRA.
Also, this is for the readVolume() API only, ATM. OTOH, there are some useful cleanups and helper classes involved that could also be used for the 2D loader, which could eventually be extended as well.