WIP: parallel version of multi_pointoperators.hxx #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from Parallelization@Vigra
Added parallel version of multi_pointoperators.hxx
minhb
changed the title
…er. Decreased dimension lenght
|
Hi, I added the parallel version of *MultiArrayData and *ScalarMultiArrayData functions (e.g. copyAddMultiArrayData) in multi_array.hxx file. I used precondition macro #ifdef OPENMP to check whether OpenMP is enabled or not. Unfortunately, I could not use #ifdef macro inside a macro definition; so, I did the other way around. I embeded macro definition (e.g. lines 245- 280) inside #ifdef region. Cheers, |
|
This PR cannot be used as is because we abandoned OpenMP in favor of std::thread. But it still contains lots of useful code, so I keep it open for now. |
ukoethe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
-I modified the way we update the number of threads involve in the paralel region. Currently, all threads update the variable num_threads. I think one thread updates this variable should be enough.
-I made the parallel version of multi_pointoperators.hxx. The test file is located in test/openmp_multi_pointoperators folder. The following functions was parallelized and partially tested: initMultiArray, copyMultiArray and transformMultiArray. The runtime performance gains with very highly dimensional array which has big dimension lenght.
Kind regards,
Minh