Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://jira.collab.test-and-trace.nhs.uk/browse/OOC-4393: OOC-4943 Update phone number validation #195

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

kathryn-dale
Copy link

Description

Update telephone validation:

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally by dev

Checklist:

  • I have performed a self-review of my own code

@masuk-kazi98
Copy link

LGTM, just a quick q. Why are we only setting one of them as required: True?

@kathryn-dale
Copy link
Author

LGTM, just a quick q. Why are we only setting one of them as required: True?

Ah I'll remove that, I was testing setting required to be false then true to make sure it worked properly for both options, as well as when there's nothing there and must have missed removing it

@kathryn-dale kathryn-dale merged commit 4d8cef3 into develop Jun 19, 2024
1 check passed
@kathryn-dale kathryn-dale deleted the feat/OOC-4943-telephone-validation branch June 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants