New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the LCI::Shared cmake target #74

Merged

JiakunYan merged 1 commit into master from fix_cmake

Oct 6, 2024

Collaborator

JiakunYan commented Oct 1, 2024

alias target can cause problems with cmake of lower version (such as 3.16).

[build] CMake Error at /path/to/LCIConfig.cmake:63 (add_library):
[build] add_library cannot create ALIAS target "LCI::LCI" because target
[build] "LCI::Shared" is imported but not globally visible.

We could either raise the minimum cmake version (as high as 3.23) or just get rid of the alias target.

I chose the latter one as I don't think we need the LCI::Shared target.


          Remove the LCI::Shared cmake target

be92b52

JiakunYan merged commit be92b52 into master

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet