Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: port to cmake #10

Open
wants to merge 5 commits into
base: v2
Choose a base branch
from
Open

Build: port to cmake #10

wants to merge 5 commits into from

Conversation

omor1
Copy link
Member

@omor1 omor1 commented Mar 11, 2020

Use cmake rather than homespun Makefiles. Includes some other fixes, notably in src/pm.c: aggressive IPO/LTO was eliminating several of the externally-visible lc_pm_xxx functions since it wasn't aware they were externally visible (go figure).

@omor1 omor1 force-pushed the v2-cmake branch 3 times, most recently from 77f033d to 356a560 Compare March 12, 2020 22:51
@danghvu
Copy link
Member

danghvu commented Apr 2, 2020

feel free to merge to v2 if this is ready, do you have permission to merge ?

@omor1
Copy link
Member Author

omor1 commented Apr 2, 2020

I wanted you to have a chance to look it over before I merged, just in case I missed anything. I'll use cmake for v21 too soon.

@danghvu
Copy link
Member

danghvu commented Apr 2, 2020

My only request is that: try to have both Makefile and cmake if possible but maybe you can try to do that in v21

@omor1
Copy link
Member Author

omor1 commented Apr 2, 2020

I think I had an issue that caused me to remove the Makefiles; I use config.h.in to configure config.h, but the build was finding the old config.h in the source. I think I might know the solution, I'll test it and see if it works. That would restrict the build to be out-of-source for cmake, but that should be done anyway.

@omor1
Copy link
Member Author

omor1 commented Apr 3, 2020

Actually, I remember the problem with config.h now: files in the same directory that #include "config.h" will find it first rather than the actual configured header in the build directory. Let me see what I can do to fix this...

@danghvu
Copy link
Member

danghvu commented Apr 3, 2020 via email

@omor1
Copy link
Member Author

omor1 commented Apr 3, 2020

My current solution was to just plop it in the top-level directory, which I don't include in the cmake build (but which is in the Makefile), but yours probably works better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants