Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing testing issues #4

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Fixing testing issues #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions libs/core/algorithms/include/hpx/parallel/util/adapt_thread_priority.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@ namespace hpx::parallel::util {
decltype(auto) adapt_thread_priority(
ExPolicy&& policy, hpx::threads::thread_priority new_priority)
{
constexpr bool supports_priority =
hpx::functional::is_tag_invocable_v<
hpx::execution::experimental::with_priority_t,
std::decay_t<ExPolicy>, hpx::threads::thread_priority>;
constexpr bool supports_priority = hpx::functional::is_tag_invocable_v<
hpx::execution::experimental::with_priority_t,
std::decay_t<ExPolicy>, hpx::threads::thread_priority>;

if constexpr (supports_priority)
{
Expand Down
2 changes: 1 addition & 1 deletion libs/core/lock_registration/include/hpx/lock_registration/detail/register_locks.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ namespace hpx::util {

// The following functions are used to store the held locks information
// during thread suspension. The data is stored on a thread_local basis,
// so we must make sure that locks the are being ignored are restored
// so we must make sure that locks that are being ignored are restored
// after suspension even if the thread is being resumed on a different core.

// retrieve the current thread_local data about held locks
Expand Down
4 changes: 3 additions & 1 deletion libs/core/synchronization/include/hpx/synchronization/shared_mutex.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@

#include <hpx/config.hpp>
#include <hpx/concurrency/cache_line_data.hpp>
#include <hpx/memory/intrusive_ptr.hpp>
#include <hpx/lock_registration/detail/register_locks.hpp>
#include <hpx/modules/memory.hpp>
#include <hpx/synchronization/detail/condition_variable.hpp>
#include <hpx/synchronization/spinlock.hpp>
#include <hpx/thread_support/assert_owns_lock.hpp>
Expand Down Expand Up @@ -65,6 +66,7 @@ namespace hpx::detail {

void release_waiters(std::unique_lock<mutex_type>& lk)
{
[[maybe_unused]] util::ignore_while_checking il(&lk);
exclusive_cond.notify_one_no_unlock(lk);
shared_cond.notify_all(HPX_MOVE(lk));
}
Expand Down
1 change: 1 addition & 0 deletions libs/full/components_base/include/hpx/components_base/server/wrapper_heap.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <hpx/naming_base/id_type.hpp>
#include <hpx/synchronization/spinlock.hpp>

#include <atomic>
#include <cstddef>
#include <cstdint>
#include <memory>
Expand Down