-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade python>=3.9 #470
Upgrade python>=3.9 #470
Conversation
@@ -44,7 +44,7 @@ def __init__(self, lock_filename, timeout=None, force=False): | |||
def get_lock_pid(self): | |||
try: | |||
return int(open(self.lock_filename).read()) | |||
except IOError: | |||
except OSError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why this is changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Python 3.3+, this exception is simple alias. OSError is actually thrown
Thanks, this is a helpful update. Ideally we should also remove |
I am currently in the process of refining and enhancing the project. Following the completion of this pull request, I intend to integrate additional linters and code formatters. By dividing the work into manageable segments, I aim to facilitate more efficient and less burdensome code reviews. |
Sounds like a plan. Will merge this in. |
If you get around to adding code formatters (I'm assuming |
Ruff is my choice. 120 OK, no problem. But I don't want to skip string normalization. It's good for consistency. I can split skip normalization in separated pr but in general I will be happy to see it enabled. |
Sorry, I happen to belong in the camp that only started using black after |
We can normalize strings to [tool.ruff.format]
quote-style = "single" |
Ok. |
3.8 is near to eol
@selwin could you check this please