-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes related to run_fcst integration #657
Merged
christinaholtNOAA
merged 10 commits into
ufs-community:main
from
christinaholtNOAA:fv3_fixes
Nov 21, 2024
Merged
Fixes related to run_fcst integration #657
christinaholtNOAA
merged 10 commits into
ufs-community:main
from
christinaholtNOAA:fv3_fixes
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christinaholtNOAA
requested review from
NaureenBharwaniNOAA,
elcarpenterNOAA,
fgabelmannjr,
maddenp-noaa,
WeirAE and
Byrnetp
as code owners
November 20, 2024 15:48
maddenp-noaa
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I made one small suggestion about a schema-enforced dict
lookup.
Co-authored-by: Paul Madden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
A small collection of changes that were needed or useful during the SRW run_fcst integration. They include:
Type
Impact
Checklist