Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes related to run_fcst integration #657

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

christinaholtNOAA
Copy link
Collaborator

Synopsis

A small collection of changes that were needed or useful during the SRW run_fcst integration. They include:

  • A fix to the lateral boundary condition logic
  • The addition of a !bool tag for YAML
  • Treating the fv3 diag_table as a template instead of a file path.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@christinaholtNOAA christinaholtNOAA self-assigned this Nov 19, 2024
Copy link
Collaborator

@maddenp-noaa maddenp-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made one small suggestion about a schema-enforced dict lookup.

src/uwtools/drivers/fv3.py Outdated Show resolved Hide resolved
@christinaholtNOAA christinaholtNOAA merged commit b00a124 into ufs-community:main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants