-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose iotaa Graphviz output #417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddenp-noaa
requested review from
NaureenBharwaniNOAA,
christinaholtNOAA,
elcarpenterNOAA,
fgabelmannjr and
WeirAE
as code owners
February 27, 2024 19:51
christinaholtNOAA
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice new experimental feature! :)
NaureenBharwaniNOAA
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
iotaa
has a feature to produce simple Graphviz DOT output depicting the state of a task graph. This PR exposes that feature for the two existinguw
drivers. I wasn't sure how well this would work, so didn't try to get any buy-in on implementing this and understand that whether we want to release this may be questionable. But here it is, for consideration.For example, here's an execution of
uw sfc_climo_gen provisioned_run_directory
with the@external
-task input files currently unavailable:Here's rendering the DOT output in
scg.dot
to a PNG file:And here's the resulting png:
After making some of the input files available:
And the new PNG file from the new DOT code:
Graphviz has different layout engines and lots of knobs to tweak to achieve more-or-less useful/interesting graphs, e.g.
We could consider marking this feature
EXPERIMENTAL
in the CLI and avoid documenting it for now.Type
Impact
Checklist