-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conda badges and update pylint #416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddenp-noaa
requested review from
christinaholtNOAA,
jprestop,
NaureenBharwaniNOAA,
elcarpenterNOAA,
fgabelmannjr and
WeirAE
as code owners
February 26, 2024 16:30
elcarpenterNOAA
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
NaureenBharwaniNOAA
approved these changes
Feb 26, 2024
christinaholtNOAA
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WeirAE
pushed a commit
to WeirAE/workflow-tools
that referenced
this pull request
Feb 27, 2024
WeirAE
added a commit
that referenced
this pull request
Feb 29, 2024
* edit config error message and test * modify error text for clarity and doc text Explicit typing doc in progress * Updated to allow YAML as output always * missed error documentation update * modified representer for f90nml * update to prod mode_config.rst for resolution * for some reason, a space * UW-509 docs for sfc_climo_gen driver (#412) * Obtain iotaa from conda-forge (#415) * Add conda badges and update pylint (#416) * modify error text for clarity and doc text Explicit typing doc in progress * Updated to allow YAML as output always * missed error documentation update * update to prod mode_config.rst for resolution * for some reason, a space * Update error message and documentation * Changes as follows below: Moved representers to support.py Moved OrderedDict logic to its own representer * updated recursive function within ordereddict * Update src/uwtools/config/support.py Co-authored-by: Paul Madden <[email protected]> * Update src/uwtools/config/support.py Co-authored-by: Paul Madden <[email protected]> * Update src/uwtools/config/support.py Co-authored-by: Paul Madden <[email protected]> * Update src/uwtools/config/support.py Co-authored-by: Paul Madden <[email protected]> * Update src/uwtools/config/support.py Co-authored-by: Paul Madden <[email protected]> * Update src/uwtools/config/support.py Co-authored-by: Paul Madden <[email protected]> * Update src/uwtools/config/support.py Co-authored-by: Paul Madden <[email protected]> * fix f90nml calls for cleanliness * consolidate representers and test * Update src/uwtools/config/support.py Co-authored-by: Paul Madden <[email protected]> * fix organization and doc string * formatting --------- Co-authored-by: Paul Madden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
pylint
URL no longer working. I updated thepylint
version and changed the URL to the "latest" link. Also updated a couple lines of code thatpylint
gave new advice about.Type
Impact
Checklist