Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UW-506 sfc_climo_gen driver #410

Merged
merged 40 commits into from
Feb 21, 2024
Merged

Conversation

maddenp-noaa
Copy link
Collaborator

@maddenp-noaa maddenp-noaa commented Feb 15, 2024

Synopsis

  • Add a driver for the sfc_climo_gen component.
  • Wired up driver to API and CLI.
  • Factored some common task logic out of uwtools.drivers.fv3 to a new uwtools.utils.tasks module for reuse.
  • Moved resources to new jsonschema/ and rocoto/ subdirectories of src/uwtools/resources, as appropriate.
  • Factored shared schemas out into individual files and added logic to load these as needed via $ref entries.
  • Colocated all granular JSON Schema tests in a single module, including new tests.
  • Factored formatting logic from Makefile out into a format script.
  • Added API module to docs.
  • Further documentation will follow in a separate PR.

See /home/Paul.Madden/run_sfc_climo_gen for an example run via the driver. The (actually YAML) config file config-scg.txt was used to drive that run, and validates with

uw config validate --schema-file src/uwtools/resources/jsonschema/sfc-climo-gen.jsonschema --input-file config-scg.txt

Type

  • Enhancement (adds a new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.

Makefile Show resolved Hide resolved
docs/sections/user_guide/index.rst Show resolved Hide resolved
format Show resolved Hide resolved
recipe/run_test.sh Show resolved Hide resolved
src/pyproject.toml Show resolved Hide resolved
src/uwtools/tests/drivers/test_fv3.py Show resolved Hide resolved
src/uwtools/tests/drivers/test_fv3.py Show resolved Hide resolved
src/uwtools/tests/support.py Show resolved Hide resolved
src/uwtools/tests/test_cli.py Show resolved Hide resolved
src/uwtools/tests/test_rocoto.py Show resolved Hide resolved
Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of content here. It looks very clean and clear. I can't seem to find anything wrong with the approach at this point. :)

src/uwtools/api/sfc_climo_gen.py Show resolved Hide resolved
src/uwtools/drivers/fv3.py Outdated Show resolved Hide resolved
src/uwtools/drivers/sfc_climo_gen.py Show resolved Hide resolved
src/uwtools/drivers/sfc_climo_gen.py Show resolved Hide resolved
@maddenp-noaa maddenp-noaa merged commit b89a788 into ufs-community:main Feb 21, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the UW-506 branch February 21, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants