Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Update ufs-weather-model hash to 5324d64 (January 7) #1178

Merged

Conversation

MichaelLueken
Copy link
Collaborator

DESCRIPTION OF CHANGES:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

TESTS CONDUCTED:

  • derecho.intel - Comprehensive, UFS-Fire WE2E, UFS-Fire Sample Config (ush/config.fire.yaml), AQM WE2E, AQM Sample Config (ush/config.aqm.yaml)

  • gaea.intel - Comprehensive, UFS-Fire WE2E

  • gaea-c6.intel - Comprehensive, UFS-Fire WE2E

  • hera.gnu - Comprehensive, UFS-Fire WE2E

  • hera.intel - Comprehensive, UFS-Fire WE2E, AQM WE2E, AQM Sample Config (ush/config.aqm.yaml)

  • hercules.intel - Comprehensive, UFS-Fire WE2E, AQM WE2E, AQM Sample Config (ush/config.aqm.yaml)

  • jet.intel - Comprehensive, UFS-Fire WE2E

  • orion.intel - Comprehensive, UFS-Fire WE2E, AQM WE2E, AQM Sample Config (ush/config.aqm.yaml)

  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

None

DOCUMENTATION:

None

ISSUE:

Fixes #857
Fixes #1176

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes

 * Externals.cfg - update ufs-weather-model hash to 5324d64 (January 7)
 * devbuild.sh - replace #!/bin/bash with #!/usr/bin/env bash
 * devclean.sh - same
 * jobs/JREGIONAL_INTEGRATION_TEST - same
 * tests/build.sh - same
 * ush/bash_utils/get_charvar_from_netcdf.sh - same
 * ush/get_layout.sh - same
 * ush/get_mrms_files.sh - same
 * ush/job_preamble.sh - same
 * ush/launch_FV3LAM_wflow.sh - same
 * ush/load_modules_run_task.sh - same
 * ush/load_modules_wflow.sh - same
 * ush/make_grid_mosaic_file.sh - same
 * ush/preamble.sh - same
Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hera:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              13.85
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20250  COMPLETE               8.76
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              27.78
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025011  COMPLETE              46.84
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20250116161  COMPLETE              26.02
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2025011616114  COMPLETE              49.18
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             172.43

Gaea-c6

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              10.10
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20250  COMPLETE               7.70
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              20.27
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025011  COMPLETE              29.48
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20250116105  COMPLETE              15.66
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2025011610580  COMPLETE              36.73
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             119.94

Passed fundamental tests on 2 machines. Approved.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Jan 22, 2025
@MichaelLueken
Copy link
Collaborator Author

The Jenkins automated testing successfully completed for Derecho, Hera GNU, Hera Intel, Hercules, Jet, and Orion.

The Jenkins runner for Gaea is down and the coverage WE2E tests have been manually submitted for that machine. Will post logs once they are complete.

The Jenkins tests on Gaea-C6 failed at the Functional WorkflowTaskTest phase due to using an invalid account. Reached out to the Platform team via the infra-help channel to see if the expected SRW_PROJECT environment variable is set to bil-fire8 on Gaea-C6. Manual testing of the failed phase shows that it successfully runs (as long as a viable account is set):

# Try gaea-c6 with the first few simple SRW tasks ...
run_make_grid: COMPLETE
run_get_ics: COMPLETE
run_get_lbcs: COMPLETE
run_make_orog: COMPLETE
run_make_sfc_climo: COMPLETE
run_make_ics: COMPLETE
run_make_lbcs: COMPLETE
run_fcst: COMPLETE
run_post: COMPLETE

and the WE2E coverage tests also successfully passed:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
community_20250122131049                                           COMPLETE              23.60
custom_ESGgrid_NewZealand_3km_20250122131050                       COMPLETE             412.39
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              35.27
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20250122131  COMPLETE              39.58
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2025012213  COMPLETE              37.37
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson  COMPLETE             422.40
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025012  COMPLETE              33.65
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_20  COMPLETE             427.84
grid_SUBCONUS_Ind_3km_ics_RAP_lbcs_RAP_suite_RRFS_v1beta_plot_202  COMPLETE              11.00
2020_CAPE_20250122131054                                           COMPLETE              40.71
2020_easter_storm_20250122131055                                   COMPLETE              40.67
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            1524.48

Once the Gaea tests have completed, I will update this PR with the results and will move forward with merging this PR.

@MichaelLueken
Copy link
Collaborator Author

The Gaea WE2E coverage tests have successfully completed:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
community_20250122115254                                           COMPLETE              80.62
custom_ESGgrid_NewZealand_3km_20250122115256                       COMPLETE             179.26
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE             142.85
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20250122115  COMPLETE             133.56
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2025012211  COMPLETE             137.98
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson  COMPLETE            1005.73
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025012  COMPLETE             143.03
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_20  COMPLETE             824.51
grid_SUBCONUS_Ind_3km_ics_RAP_lbcs_RAP_suite_RRFS_v1beta_plot_202  COMPLETE              47.43
2020_CAPE_20250122115317                                           COMPLETE             138.04
2020_easter_storm_20250122115319                                   COMPLETE             138.15
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            2971.16

Moving forward with merging this PR now.

@MichaelLueken MichaelLueken merged commit 9ca68c5 into ufs-community:develop Jan 22, 2025
4 of 6 checks passed
@MichaelLueken MichaelLueken deleted the feature/hash_update_01_2025 branch January 23, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
3 participants