[develop] Port SRW to Gaea C6 #1163
Open
+241
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passed comprehensive tests: For runs used UFS-WM branch: https://github.com/BrianCurtis-NOAA/ufs-weather-model.git -b gaeac6 PR#2448 |
|
@RatkoVasic-NOAA I have discussed the Jenkins labels for Gaea-C5 and Gaea-C6 with Kris Booker. The newly added I'm working in a copy of your branch to remove |
|
@MichaelLueken that's OK. I'm currently running tests on: Hera, Hercules, Jet, Orion, Gaea-C5, Gaea-C6, and Derecho. Some are already done. I'll retest gaea-c5 after your changes. |
|
@RatkoVasic-NOAA The majority of the modifications have been made and the both the automated build script ( |
|
Hera: Jet: Gaea-c6: Orion: Hercules: Derecho: |
|
@RatkoVasic-NOAA PR #15 was created in your fork. Once merged, this PR will be ready for review. |
[gaea-c6] Replace gaea-c5 with gaea to allow Jenkins automated testing to pass
RatkoVasic-NOAA
requested review from
mkavulich,
gsketefian,
JeffBeck-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA and
christopherwharrop-noaa
as code owners
RatkoVasic-NOAA
requested review from
danielabdi-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
dmwright526,
gspetro-NOAA,
natalie-perlin,
EdwardSnyder-NOAA,
MichaelLueken,
rickgrubin-noaa,
BruceKropp-Raytheon,
BenKoziol-NOAA and
WeirAE
as code owners
MichaelLueken
requested changes
Jan 9, 2025
There was a problem hiding this comment.
I'm building the SRW App on Gaea-C6 using the Jenkins scripts. Once built, I will run the fundamental WE2E tests using the Jenkins scripts as well. I'll run the Jenkins task test script after the fundamental tests successfully finish. I should be able to approve the changes once those tests are complete.
I noted one minor issue with the doc/UsersGuide/CustomizingTheWorkflow/ConfigWorkflow.rst file. There is still mention of GAEA-C5 and GAEA-C6, rather than GAEA and GAEA-C6. Please remove the -C5 from GAEA-C5 on line 33 of the rst file.
|
The Jenkins Submitting the |
|
The |
MichaelLueken
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Thanks for making the change, @RatkoVasic-NOAA! Everything looks great and the Jenkins scripts are working correctly on Gaea-C6. I will now approve this PR.
|
I was also able to successfully run the UFS-Fire WE2E tests on Gaea-C6: |
|
Ran fundamental test on Gaea c6 and it passed: Experienced strange behaviors were the devbuild script didn't build the |
EdwardSnyder-NOAA
approved these changes
Jan 10, 2025
MichaelLueken
added
the
run_we2e_jenkins_coverage_tests
|
Jenkins is not yet running on Gaea-C6, so I will manually run the coverage tests on that machine. Additionally, Hera epic space has exceeded disk quota, so will manually run in stmp space. |
|
The coverage tests have successfully passed on Gaea-C6: |
|
The Hera Intel coverage WE2E tests have successfully passed: |
|
@RatkoVasic-NOAA @MichaelLueken , I am trying to run the sample configuration The Do you have any idea what is wrong? I am using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Enable SRW for new machine Gaea-C6
NOTE1: needs to update SRW to new UFS-WM version (after PR2448)
NOTE2: on Gaea C6 for tests use account bil-fire8, not epic, i.e. ./run_WE2E_tests.py -t fundamental -m gaea-c6 -a bil-fire8
UFS_SRW_data copied to /gpfs/f6/bil-fire8/world-shared/UFS_SRW_data location.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
rst files updated.
ISSUE:
Closes issue #1120
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR: