Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rules] [strings] Add support for concat_split rule and splitted rules in prefix and suffix version #35

Merged
merged 7 commits into from
May 8, 2024

Conversation

vinisilvag
Copy link
Contributor

This PR adds the concat_csplit rule from the Strings theory.
Rule reference can be found in the cvc5 documentation and in the AletheLF specification.

Furthermore, it:

  • Splits the rule into two versions: application over prefixes and over suffixes;
  • Makes the necessary modifications to allow other rules to be split in this way;
  • Standardizes variable names to how they appear in AletheLF documentation;
  • Fixes a bug in the function that creates Skolems in the concat_csplit rule.

@vinisilvag vinisilvag force-pushed the concat-split-rule branch from 9de4082 to 8bde740 Compare May 7, 2024 22:11
Copy link
Collaborator

@bpandreotti bpandreotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos

carcara/src/checker/rules/strings.rs Outdated Show resolved Hide resolved
carcara/src/checker/rules/strings.rs Outdated Show resolved Hide resolved
@bpandreotti bpandreotti merged commit 04cbe27 into ufmg-smite:main May 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants