forked from DSpace/DSpace
-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'file-downloader' into customer/uk
- Loading branch information
Showing
5 changed files
with
380 additions
and
0 deletions.
There are no files selected for viewing
194 changes: 194 additions & 0 deletions
194
dspace-api/src/main/java/org/dspace/administer/FileDownloader.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,194 @@ | ||
/** | ||
* The contents of this file are subject to the license and copyright | ||
* detailed in the LICENSE and NOTICE files at the root of the source | ||
* tree and available online at | ||
* | ||
* http://www.dspace.org/license/ | ||
*/ | ||
package org.dspace.administer; | ||
|
||
import java.io.IOException; | ||
import java.io.InputStream; | ||
import java.net.URI; | ||
import java.net.URISyntaxException; | ||
import java.net.http.HttpClient; | ||
import java.net.http.HttpRequest; | ||
import java.net.http.HttpResponse; | ||
import java.sql.SQLException; | ||
import java.util.List; | ||
import java.util.UUID; | ||
import java.util.stream.Stream; | ||
|
||
import org.apache.commons.cli.ParseException; | ||
import org.dspace.authorize.AuthorizeException; | ||
import org.dspace.content.Bitstream; | ||
import org.dspace.content.BitstreamFormat; | ||
import org.dspace.content.Bundle; | ||
import org.dspace.content.Item; | ||
import org.dspace.content.factory.ContentServiceFactory; | ||
import org.dspace.content.service.BitstreamFormatService; | ||
import org.dspace.content.service.BitstreamService; | ||
import org.dspace.content.service.ItemService; | ||
import org.dspace.core.Context; | ||
import org.dspace.eperson.EPerson; | ||
import org.dspace.eperson.factory.EPersonServiceFactory; | ||
import org.dspace.eperson.service.EPersonService; | ||
import org.dspace.scripts.DSpaceRunnable; | ||
import org.dspace.scripts.configuration.ScriptConfiguration; | ||
import org.dspace.utils.DSpace; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
|
||
|
||
public class FileDownloader extends DSpaceRunnable<FileDownloaderConfiguration> { | ||
|
||
private static final Logger log = LoggerFactory.getLogger(FileDownloader.class); | ||
private boolean help = false; | ||
private UUID itemUUID; | ||
private URI uri; | ||
private String epersonMail; | ||
private String bitstreamName; | ||
private EPersonService epersonService; | ||
private ItemService itemService; | ||
private BitstreamService bitstreamService; | ||
private BitstreamFormatService bitstreamFormatService; | ||
private final HttpClient httpClient = HttpClient.newBuilder() | ||
.followRedirects(HttpClient.Redirect.NORMAL) | ||
.build(); | ||
|
||
/** | ||
* This method will return the Configuration that the implementing DSpaceRunnable uses | ||
* | ||
* @return The {@link ScriptConfiguration} that this implementing DspaceRunnable uses | ||
*/ | ||
@Override | ||
public FileDownloaderConfiguration getScriptConfiguration() { | ||
return new DSpace().getServiceManager().getServiceByName("file-downloader", | ||
FileDownloaderConfiguration.class); | ||
} | ||
|
||
/** | ||
* This method has to be included in every script and handles the setup of the script by parsing the CommandLine | ||
* and setting the variables | ||
* | ||
* @throws ParseException If something goes wrong | ||
*/ | ||
@Override | ||
public void setup() throws ParseException { | ||
log.debug("Setting up {}", FileDownloader.class.getName()); | ||
if (commandLine.hasOption("h")) { | ||
help = true; | ||
return; | ||
} | ||
|
||
if (!commandLine.hasOption("u")) { | ||
throw new ParseException("No URL option has been provided"); | ||
} | ||
|
||
if (!commandLine.hasOption("i")) { | ||
throw new ParseException("No item option has been provided"); | ||
} | ||
|
||
if (getEpersonIdentifier() == null && !commandLine.hasOption("e")) { | ||
throw new ParseException("No eperson option has been provided"); | ||
} | ||
|
||
|
||
this.epersonService = EPersonServiceFactory.getInstance().getEPersonService(); | ||
this.itemService = ContentServiceFactory.getInstance().getItemService(); | ||
this.bitstreamService = ContentServiceFactory.getInstance().getBitstreamService(); | ||
this.bitstreamFormatService = ContentServiceFactory.getInstance().getBitstreamFormatService(); | ||
|
||
try { | ||
uri = new URI(commandLine.getOptionValue("u")); | ||
} catch (URISyntaxException e) { | ||
throw new ParseException("The provided URL is not a valid URL"); | ||
} | ||
itemUUID = UUID.fromString(commandLine.getOptionValue("i")); | ||
|
||
epersonMail = commandLine.getOptionValue("e"); | ||
|
||
if (commandLine.hasOption("n")) { | ||
bitstreamName = commandLine.getOptionValue("n"); | ||
} | ||
} | ||
|
||
/** | ||
* This method has to be included in every script and this will be the main execution block for the script that'll | ||
* contain all the logic needed | ||
* | ||
* @throws Exception If something goes wrong | ||
*/ | ||
@Override | ||
public void internalRun() throws Exception { | ||
log.debug("Running {}", FileDownloader.class.getName()); | ||
if (help) { | ||
printHelp(); | ||
return; | ||
} | ||
|
||
Context context = new Context(); | ||
context.setCurrentUser(getEperson(context)); | ||
|
||
// Download the file from the given url | ||
// and save it to the item with the given UUID | ||
|
||
//find the item by the given uuid | ||
Item item = itemService.find(context, itemUUID); | ||
if (item == null) { | ||
throw new IllegalArgumentException("No item found for the given UUID"); | ||
} | ||
|
||
HttpRequest request = HttpRequest.newBuilder() | ||
.uri(uri) | ||
.build(); | ||
|
||
HttpResponse<InputStream> response = httpClient.send(request, HttpResponse.BodyHandlers.ofInputStream()); | ||
|
||
if (response.statusCode() >= 400) { | ||
throw new IllegalArgumentException("The provided URL returned a status code of " + response.statusCode()); | ||
} | ||
|
||
//use the provided value, the content-disposition header, the last part of the uri | ||
if (bitstreamName == null) { | ||
bitstreamName = response.headers().firstValue("Content-Disposition") | ||
.filter(value -> value.contains("filename=")).flatMap(value -> Stream.of(value.split(";")) | ||
.filter(v -> v.contains("filename=")) | ||
.findFirst() | ||
.map(fvalue -> fvalue.replaceFirst("filename=", "").replaceAll("\"", ""))) | ||
.orElse(uri.getPath().substring(uri.getPath().lastIndexOf('/') + 1)); | ||
} | ||
|
||
try (InputStream is = response.body()) { | ||
saveFileToItem(context, item, is, bitstreamName); | ||
} | ||
|
||
context.commit(); | ||
} | ||
|
||
private void saveFileToItem(Context context, Item item, InputStream is, String name) | ||
throws SQLException, AuthorizeException, IOException { | ||
log.debug("Saving file to item {}", item.getID()); | ||
List<Bundle> originals = item.getBundles("ORIGINAL"); | ||
Bitstream b; | ||
if (originals.isEmpty()) { | ||
b = itemService.createSingleBitstream(context, is, item); | ||
} else { | ||
Bundle bundle = originals.get(0); | ||
b = bitstreamService.create(context, bundle, is); | ||
} | ||
b.setName(context, name); | ||
//now guess format of the bitstream | ||
BitstreamFormat bf = bitstreamFormatService.guessFormat(context, b); | ||
b.setFormat(context, bf); | ||
} | ||
|
||
private EPerson getEperson(Context context) throws SQLException { | ||
if (getEpersonIdentifier() != null) { | ||
return epersonService.find(context, getEpersonIdentifier()); | ||
} else { | ||
return epersonService.findByEmail(context, epersonMail); | ||
} | ||
} | ||
} | ||
|
66 changes: 66 additions & 0 deletions
66
dspace-api/src/main/java/org/dspace/administer/FileDownloaderConfiguration.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/** | ||
* The contents of this file are subject to the license and copyright | ||
* detailed in the LICENSE and NOTICE files at the root of the source | ||
* tree and available online at | ||
* | ||
* http://www.dspace.org/license/ | ||
*/ | ||
package org.dspace.administer; | ||
|
||
import org.apache.commons.cli.Options; | ||
import org.dspace.scripts.configuration.ScriptConfiguration; | ||
|
||
public class FileDownloaderConfiguration extends ScriptConfiguration<FileDownloader> { | ||
|
||
private Class<FileDownloader> dspaceRunnableClass; | ||
|
||
/** | ||
* Generic getter for the dspaceRunnableClass | ||
* | ||
* @return the dspaceRunnableClass value of this ScriptConfiguration | ||
*/ | ||
@Override | ||
public Class<FileDownloader> getDspaceRunnableClass() { | ||
return dspaceRunnableClass; | ||
} | ||
|
||
/** | ||
* Generic setter for the dspaceRunnableClass | ||
* | ||
* @param dspaceRunnableClass The dspaceRunnableClass to be set on this IndexDiscoveryScriptConfiguration | ||
*/ | ||
@Override | ||
public void setDspaceRunnableClass(Class<FileDownloader> dspaceRunnableClass) { | ||
this.dspaceRunnableClass = dspaceRunnableClass; | ||
} | ||
|
||
/** | ||
* The getter for the options of the Script | ||
* | ||
* @return the options value of this ScriptConfiguration | ||
*/ | ||
@Override | ||
public Options getOptions() { | ||
if (options == null) { | ||
|
||
Options options = new Options(); | ||
|
||
options.addOption("h", "help", false, "help"); | ||
|
||
options.addOption("u", "url", true, "source url"); | ||
options.getOption("u").setRequired(true); | ||
|
||
options.addOption("i", "item", true, "item uuid"); | ||
options.getOption("i").setRequired(true); | ||
|
||
options.addOption("e", "eperson", true, "eperson email"); | ||
options.getOption("e").setRequired(false); | ||
|
||
options.addOption("n", "name", true, "name of the file/bitstream"); | ||
options.getOption("n").setRequired(false); | ||
|
||
super.options = options; | ||
} | ||
return options; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
dspace-api/src/test/java/org/dspace/administer/FileDownloaderIT.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
/** | ||
* The contents of this file are subject to the license and copyright | ||
* detailed in the LICENSE and NOTICE files at the root of the source | ||
* tree and available online at | ||
* | ||
* http://www.dspace.org/license/ | ||
*/ | ||
package org.dspace.administer; | ||
|
||
import static org.junit.Assert.assertEquals; | ||
import static org.junit.Assert.assertNotNull; | ||
import static org.mockserver.model.HttpRequest.request; | ||
import static org.mockserver.model.HttpResponse.response; | ||
|
||
import java.util.List; | ||
|
||
import org.dspace.AbstractIntegrationTestWithDatabase; | ||
import org.dspace.builder.CollectionBuilder; | ||
import org.dspace.builder.CommunityBuilder; | ||
import org.dspace.builder.ItemBuilder; | ||
import org.dspace.content.Bitstream; | ||
import org.dspace.content.Collection; | ||
import org.dspace.content.Community; | ||
import org.dspace.content.Item; | ||
import org.dspace.content.factory.ContentServiceFactory; | ||
import org.dspace.content.service.BitstreamService; | ||
import org.junit.Before; | ||
import org.junit.Rule; | ||
import org.junit.Test; | ||
import org.mockserver.junit.MockServerRule; | ||
|
||
|
||
public class FileDownloaderIT extends AbstractIntegrationTestWithDatabase { | ||
|
||
@Rule | ||
public MockServerRule mockServerRule = new MockServerRule(this); | ||
|
||
private Item item; | ||
|
||
//Prepare a community and a collection before the test | ||
@Before | ||
@Override | ||
public void setUp() throws Exception { | ||
super.setUp(); | ||
context.setCurrentUser(admin); | ||
Community community = CommunityBuilder.createCommunity(context).build(); | ||
Collection collection = CollectionBuilder.createCollection(context, community).build(); | ||
item = ItemBuilder.createItem(context, collection).withTitle("FileDownloaderIT Item").build(); | ||
|
||
mockServerRule.getClient().when(request() | ||
.withMethod("GET") | ||
.withPath("/test400") | ||
).respond( | ||
response() | ||
.withStatusCode(400) | ||
.withBody("test") | ||
); | ||
|
||
mockServerRule.getClient().when(request() | ||
.withMethod("GET") | ||
.withPath("/test") | ||
).respond( | ||
response() | ||
.withStatusCode(200) | ||
.withHeader("Content-Disposition", "attachment; filename=\"test.txt\"") | ||
.withBody("test") | ||
); | ||
} | ||
|
||
//Test that when an error occurs no bitstream is actually added to the item | ||
@Test() | ||
public void testDownloadFileError() throws Exception { | ||
|
||
|
||
BitstreamService bitstreamService = ContentServiceFactory.getInstance().getBitstreamService(); | ||
int oldBitCount = bitstreamService.countTotal(context); | ||
|
||
int port = mockServerRule.getPort(); | ||
String[] args = new String[]{"file-downloader", "-i", item.getID().toString(), | ||
"-u", String.format("http://localhost:%s/test400", port), "-e", "[email protected]"}; | ||
try { | ||
runDSpaceScript(args); | ||
} catch (IllegalArgumentException e) { | ||
assertEquals(0, item.getBundles().size()); | ||
int newBitCount = bitstreamService.countTotal(context); | ||
assertEquals(oldBitCount, newBitCount); | ||
return; | ||
} | ||
assertEquals(0, 1); | ||
} | ||
|
||
|
||
//Test that FileDownlaoder actually adds the bitstream to the item | ||
@Test | ||
public void testDownloadFile() throws Exception { | ||
|
||
int port = mockServerRule.getPort(); | ||
String[] args = new String[] {"file-downloader", "-i", item.getID().toString(), | ||
"-u", String.format("http://localhost:%s/test", port), "-e", "[email protected]"}; | ||
runDSpaceScript(args); | ||
|
||
|
||
assertEquals(1, item.getBundles().size()); | ||
List<Bitstream> bs = item.getBundles().get(0).getBitstreams(); | ||
assertEquals(1, bs.size()); | ||
assertNotNull("Expecting name to be defined", bs.get(0).getName()); | ||
|
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters