Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: add missing await in "Editing a document locally" example. #888

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

blep
Copy link
Contributor

@blep blep commented Dec 17, 2024

DirectConnection.disconnect() is an async function and should be await to wait for its promise to complete.

Notes: experienced C++/Java dev, but total Typescript beginner, so make sure to check.

Copy link
Collaborator

@janthurau janthurau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janthurau janthurau merged commit ca664b0 into ueberdosis:main Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants