-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Implement a fix to restore the delete button's functionality and enable deletion. #254 #537
Open
AK1239
wants to merge
10
commits into
udsm-dhis2-lab:main
Choose a base branch
from
AK1239:fix/delete-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, everyone!
For those who have completed their assignment tasks, please follow these
steps to submit your work:
1.
*Create a Feature Branch*
- Name the branch based on the task you're working on, e.g.,
feature/labnotification.
2.
*Push Your Work*
- Push all your changes to the newly created feature branch.
3.
*Create a Pull Request*
- Create a pull request directed to the account named iamgaspardev for
review of your work.
*Note:*
- Do not push changes to your personal GitHub account.
- Push from the repository you pulled from and ensure the changes are in
the feature branch you created.
Thanks and Regards,
Ramadhani Mbiaji
Health Information System Analyst
UDSM DHIS2 LAB <https://dhis2.udsm.ac.tz/#/home>
College of Information and Communication Technology (CoICT)
Department of Computer Science and Engineering
University of Dar-es-salaam
Mobile Number: *+255 693 012 480*
Useful Links: GitHub <https://github.com/Ramadhani202208>, LinkedIn
<https://www.linkedin.com/in/ramadhani-mbiaji-2881b0ab/>
Website: https://dhis2.udsm.ac.tz
…On Fri, 17 Jan 2025 at 15:08, Akil Khatri ***@***.***> wrote:
We group 13 implemented a fix to restore the delete button functionality.
How does the bug occur?
After clicking the theatre module, and clicking on a patients name, the
delete functionality wasnt working
How did we solve it?
Added a field of voided, and made sure to filter out voided orders, so
that the UI reflects correctly what is deleted
Group members:
1.Awadhi Sadi Shemliwa 2022-04-12305
2.Akil Mahmood Khatri 2022-04-04053
3.Ahlaam Faiz Abdallah 2022-04-00032
4.Iddy Jumanne Semauya 2022-04-12101
5.Abdulqadir Mohamed Msingi 2022-04-08569
------------------------------
You can view, comment on, or merge this pull request online at:
#537
Commit Summary
- ab69768
<ab69768>
fix: the theatre module page was not loading, removing this made it load
- a6b9d6e
<a6b9d6e>
fix: added a void field to indicate to detect whether a procedure has been
deleted or not
- 3e408f7
<3e408f7>
fix: added a check to see if procedure is void or not
- 017d41e
<017d41e>
fix: explained how the workflow process works and how deletion is carried
out
- 22b76ab
<22b76ab>
explained the workflow of how the filtering works
- 6ea8940
<6ea8940>
Merge branch 'fix/delete-button' of
https://github.com/AK1239/iCareConnect into fix/delete-button
- 063c8b1
<063c8b1>
changes in sanitize-visit-details file
- e55bdd1
<e55bdd1>
changes in sanitize-visit-details file
- 69e401a
<69e401a>
changes in patient procedure file
- 4d50e64
<4d50e64>
Merge branch 'fix/delete-button' of
https://github.com/AK1239/iCareConnect into fix/delete-button
File Changes
(3 files <https://github.com/udsm-dhis2-lab/iCareConnect/pull/537/files>)
- *M*
ui/src/app/modules/theatre/pages/theatre-dashboard/theatre-dashboard.component.html
<https://github.com/udsm-dhis2-lab/iCareConnect/pull/537/files#diff-7f297e5b9cb6e3b9ef9cfeee8eb9a9d46726db31bd9927bda04890baf28cf0a8>
(37)
- *M*
ui/src/app/shared/components/patient-procedures-summary/patient-procedures-summary.component.ts
<https://github.com/udsm-dhis2-lab/iCareConnect/pull/537/files#diff-d902c38d083ae7813212fdd4d5c4aacf9d95aad4d39e43c78031706781706fcc>
(3)
- *M*
ui/src/app/shared/resources/visits/helpers/sanitize-visit-details.helper.ts
<https://github.com/udsm-dhis2-lab/iCareConnect/pull/537/files#diff-0989031ad02d1f52702434565149ce031a8a0bd6aa4e009f0c16ad8a761f7232>
(8)
Patch Links:
- https://github.com/udsm-dhis2-lab/iCareConnect/pull/537.patch
- https://github.com/udsm-dhis2-lab/iCareConnect/pull/537.diff
—
Reply to this email directly, view it on GitHub
<#537>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2TLCLCLQ3SC6A5GDWBGKLT2LDXDRAVCNFSM6AAAAABVLY22UOVHI2DSMVQWIX3LMV43ASLTON2WKOZSG44TKMZTGA2TCMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We group 13 implemented a fix to restore the delete button functionality.
How does the bug occur?
After clicking the theatre module, and clicking on a patients name, the delete functionality wasnt working
How did we solve it?
Added a field of voided, and made sure to filter out voided orders, so that the UI reflects correctly what is deleted
Group members:
1.Awadhi Sadi Shemliwa 2022-04-12305
2.Akil Mahmood Khatri 2022-04-04053
3.Ahlaam Faiz Abdallah 2022-04-00032
4.Iddy Jumanne Semauya 2022-04-12101
5.Abdulqadir Mohamed Msingi 2022-04-08569