Fixed lab results provider display bug

[G-first-t]

Bug Summary:
The lab results in the patient history were incorrectly displaying the doctor's name instead of the technician who fed the results into the system.

Cause:
The results array for labOrders was not correctly prioritizing the fedBy property (technician) over the provider property (doctor). This caused the UI to show the doctor as the provider of the results.

Fix:
Updated the logic in this.labOrders mapping:

• Added a map transformation to ensure the provider field prioritizes the fedBy value.
• Simplified the filter logic to directly match orders and observations by UUID.

Pull Request:
PR #529 - Fixed lab results provider display bug

Participants:

• 2022-04-04347: Gregory Kimbira
• 2022-04-12587: Julius Ryoba
• 2022-04-10077: Adrian Justine Ndossi
• 2022-04-09572: kelvin Augustino
• 2022-04-05771: Samson Maige

[Moricembiaji]

Hello, everyone! For those who have completed their assignment tasks, please follow these steps to submit your work: 1. *Create a Feature Branch* - Name the branch based on the task you're working on, e.g., feature/labnotification. 2. *Push Your Work* - Push all your changes to the newly created feature branch. 3. *Create a Pull Request* - Create a pull request directed to the account named iamgaspardev for review of your work. *Note:* - Do not push changes to your personal GitHub account. - Push from the repository you pulled from and ensure the changes are in the feature branch you created. Thanks and Regards, Ramadhani Mbiaji Health Information System Analyst UDSM DHIS2 LAB <https://dhis2.udsm.ac.tz/#/home> College of Information and Communication Technology (CoICT) Department of Computer Science and Engineering University of Dar-es-salaam Mobile Number: *+255 693 012 480* Useful Links: GitHub <https://github.com/Ramadhani202208>, LinkedIn <https://www.linkedin.com/in/ramadhani-mbiaji-2881b0ab/> Website: https://dhis2.udsm.ac.tz

…

On Fri, 17 Jan 2025 at 10:49, KIMBIRA Gregory Robert < ***@***.***> wrote: *Bug Summary:* The lab results in the patient history were incorrectly displaying the doctor's name instead of the technician who fed the results into the system. *Cause:* The results array for labOrders was not correctly prioritizing the fedBy property (technician) over the provider property (doctor). This caused the UI to show the doctor as the provider of the results. *Fix:* Updated the logic in this.labOrders mapping: - Added a map transformation to ensure the provider field prioritizes the fedBy value. - Simplified the filter logic to directly match orders and observations by UUID. *Pull Request:* PR #456 - Fixed lab results provider display bug <https://github.com/udsm-dhis2-lab/iCareConnect/compare/main...G-first-t:iCareConnect:main?expand=1> *Participants:* - 2022-04-04347: Gregory Kimbira - 2022-04-12587: Julius Ryoba - 2022-04-10077: Adrian Justine Ndossi - 2022-04-09572: kelvin Augustino - 2022-04-05771: Samson Maige ------------------------------ You can view, comment on, or merge this pull request online at: #529 Commit Summary - 57f7d22 <57f7d22> Refactored labOrders mapping logic to prioritize technicians over doctors File Changes (1 file <https://github.com/udsm-dhis2-lab/iCareConnect/pull/529/files>) - *M* ui/src/app/shared/components/patient-history-data/patient-history-data.component.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/529/files#diff-c0a1e56024600e4184aa1bb676b92746d485c27437f5a5737f54bb3a60416777> (13) Patch Links: - https://github.com/udsm-dhis2-lab/iCareConnect/pull/529.patch - https://github.com/udsm-dhis2-lab/iCareConnect/pull/529.diff — Reply to this email directly, view it on GitHub <#529>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A2TLCLH3QDNWOMPPPLEMOXD2LCY2JAVCNFSM6AAAAABVLKMLX6VHI2DSMVQWIX3LMV43ASLTON2WKOZSG44TIOBQGMZTIOA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>