Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed section 3 to be readable in markdown #252

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tdunning
Copy link

Apparently in the move to github, the license got converted to markdown.

Unfortunately, this rendered section 3 nearly unreadable even though the original raw text was pretty clear.

To remedy this, I inserted nested list annotations so that the original structure is visible in the rendered form.

@tdunning
Copy link
Author

tdunning commented Dec 8, 2022

Can somebody review and accept (or correct) this minor update?

@gschadow @dr-shorthair ?

@tdunning
Copy link
Author

I will be deleting this pull request in a few days if it is not acted on.

@tdunning
Copy link
Author

This still hasn't been merged. Should it be marked as WONT-FIX?

Copy link

@chgessner chgessner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for my eyes.

@dr-shorthair
Copy link

I believe @timbrisc is currently the only member with write-permission.

Copy link

@gschadow gschadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@gschadow
Copy link

There seems to be a bug or misconfiguration with github.

image

we now have 3 approvals, I have just added mine, refreshed the page, and it's still telling me to add my review. It also tells me that merging can be performed automatically with one 1 approving review. That one more. Feels like being a horse running after the carrot dangling in front of my nose. Haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants