Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide pii walkthrough on small screens #1456

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Hide pii walkthrough on small screens #1456

merged 1 commit into from
Oct 7, 2020

Conversation

eAlasdair
Copy link
Contributor

Relates to #1455

Draft because we should answer the question: Do we want to 'fix' it this way? before we think about actually merging it

@eAlasdair eAlasdair added bug Something isn't working suggestion labels Oct 6, 2020
@eAlasdair eAlasdair self-assigned this Oct 6, 2020
@courtneycb
Copy link
Contributor

courtneycb commented Oct 7, 2020 •
edited
Loading

I think we do this in CodeWOF?

I think it would be good to have this at least as a short term fix, and we can leave the issue open.

@eAlasdair eAlasdair marked this pull request as ready for review October 7, 2020 02:20
@eAlasdair eAlasdair requested a review from courtneycb October 7, 2020 02:20
@eAlasdair eAlasdair merged commit e048c0d into develop Oct 7, 2020
@eAlasdair eAlasdair deleted the issue/1455 branch October 7, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@courtneycb courtneycb courtneycb approved these changes

Assignees

@eAlasdair eAlasdair

Labels
bug Something isn't working suggestion
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eAlasdair @courtneycb