Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appendix pages to search #2498

Merged
merged 17 commits into from
May 9, 2024
Merged

Add appendix pages to search #2498

merged 17 commits into from
May 9, 2024

Conversation

jimbonothing64
Copy link
Contributor

@jimbonothing64 jimbonothing64 commented Feb 2, 2024

Proposed changes

fixes #1824
Add appendix pages to the search feature. The pages contributors, about and sitemap will show up in the search -- with a relatively low weighting.
Changes:

  • Appendices are now stored in the database
  • Appendices are indexed for search by their name, and text content (from template)
  • Appendices loader now loads appendices into the DB
  • Existing tests for appendix app re-enabled and updated
  • Tests for appendix model
  • Tests for get_template_text function
  • Tests for appendix loader

@JackMorganNZ
Copy link
Member

@jimbonothing64 If you need help getting this working, I'm happy to take a look at it sometime.

@jimbonothing64 jimbonothing64 changed the title Add appendix pages to search WIP: Add appendix pages to search Mar 15, 2024
@jimbonothing64
Copy link
Contributor Author

jimbonothing64 commented Mar 15, 2024

@jimbonothing64 If you need help getting this working, I'm happy to take a look at it sometime.

Thanks @JackMorganNZ !

I've been blocked by other work for the last month (likely the next ~2 weeks too). Getting the dev staging CD deploying again is the next priority. I chose this issue for good tour of the project -- it's not my urgent list.

I'm a month out of touch, but from memory, the main area was familiarizing myself with the loader testing setup. Perhaps you've spotted something else, however. If you want to and have the time, it would be instructive if you had any advice/pointers -- but understandable if not!

Thanks again.

@jimbonothing64 jimbonothing64 changed the title WIP: Add appendix pages to search Add appendix pages to search May 9, 2024
@jimbonothing64 jimbonothing64 enabled auto-merge May 9, 2024 23:17
@jimbonothing64 jimbonothing64 disabled auto-merge May 9, 2024 23:18
@jimbonothing64 jimbonothing64 merged commit f17373b into develop May 9, 2024
10 checks passed
@jimbonothing64 jimbonothing64 deleted the issue/1824 branch May 9, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

About and contributors page not indexed for search
2 participants