Merge branch 'master' of https://github.com/ucbds-infra/otter-grader

.github/stale.yml

@@ -6,6 +6,7 @@ daysUntilClose: 7
 exemptLabels:
   - pinned
   - security
+  - TODO
 # Label to use when marking an issue as stale
 staleLabel: wontfix
 # Comment to post when marking an issue as stale. Set to `false` to disable

otter/check/utils.py

@@ -22,27 +22,26 @@ def save_notebook(filename, timeout=10):
     Args:
         filename (``str``): path to notebook file being saved
         timeout (``int`` or ``float``): number of seconds to wait for save before timing-out
-    
+
     Returns
         ``bool``: whether the notebook was saved successfully
     """
     timeout = timeout * 10**9
     if get_ipython() is not None:
-        f = open(filename, "rb")
-        md5 = hashlib.md5(f.read()).hexdigest()
+        with open(filename, "rb") as f:
+            md5 = hashlib.md5(f.read()).hexdigest()
         start = time.time_ns()
         display(Javascript("Jupyter.notebook.save_checkpoint();"))
-        
+
         curr = md5
         while curr == md5 and time.time_ns() - start <= timeout:
             time.sleep(1)
-            f.seek(0)
-            curr = hashlib.md5(f.read()).hexdigest()
-
-        f.close()
+            with open(filename, "rb") as f:
+                curr = hashlib.md5(f.read()).hexdigest()
+
 
         return curr != md5
-    
+
     return True