Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to dedup ILMs after both syn_map and syn_generic #826

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Attempt to dedup ILMs after both syn_map and syn_generic #826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions hammer/synthesis/genus/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,27 @@ def retime_modules(self) -> bool:

return True

def dedup_ilms(self) -> None:
"""After DDI, syn_generic and syn_map will sometimes uniquify hierarchical ILMs,
despite .preserve being set on the ILM modules. From observation, the uniquified
modules are identical to the read-in ILM, so we can safely change_link to
dedup.

TODO: Correctly disable uniquification in Genus for hierarchical blocks"""

if self.hierarchical_mode.is_nonleaf_hierarchical() and self.version() >= self.version_number("211"):
pcs = list(filter(lambda c: c.type == PlacementConstraintType.Hierarchical, self.get_placement_constraints()))
for pc in pcs:
self.append("""
# Attempt to deuniquify hinst:{inst}, incase it was uniquified
set uniquified_name [get_db hinst:{inst} .module.name]
if {{ $uniquified_name ne \"{master}\" }} {{
puts [format \"WARNING: instance hinst:{inst} was uniquified to be an instance of $uniquified_name, not {master}. Attempting to fix\"]
change_link -copy_attributes -instances {{{inst}}} -design_name module:{top}/{master}
}}
set_db hinst:{inst} .preserve true
""".format(inst=pc.path, top=self.top_module, master=pc.master))

def syn_generic(self) -> bool:
# Add clock mapping flow if special cells are specified
if self.version() >= self.version_number("211"):
Expand All @@ -303,17 +324,7 @@ def syn_generic(self) -> bool:
self.append("set_db map_clock_tree true")
self.verbose_append("syn_generic")

# With DDI, hierarchical instances may be uniquified. Use change_link to deuniquify them
if self.hierarchical_mode.is_nonleaf_hierarchical() and self.version() >= self.version_number("211"):
pcs = list(filter(lambda c: c.type == PlacementConstraintType.Hierarchical, self.get_placement_constraints()))
for pc in pcs:
self.append("""
# Attempt to deuniquify hinst:{inst}, incase it was uniquified
set uniquified_name [get_db hinst:{inst} .module.name]
if {{ $uniquified_name ne \"{master}\" }} {{
puts [format \"WARNING: instance hinst:{inst} was uniquified to be an instance of $uniquified_name, not {master}. Attempting to fix\"]
change_link -copy_attributes -instances {{{inst}}} -design_name module:{top}/{master}
}}""".format(inst=pc.path, top=self.top_module, master=pc.master))
self.dedup_ilms()

return True

Expand All @@ -322,6 +333,9 @@ def syn_map(self) -> bool:
# Need to suffix modules for hierarchical simulation if not top
if self.hierarchical_mode not in [HierarchicalMode.Flat, HierarchicalMode.Top]:
self.verbose_append("update_names -module -log hier_updated_names.log -suffix _{MODULE}".format(MODULE=self.top_module))

self.dedup_ilms()

return True

def add_tieoffs(self) -> bool:
Expand Down