Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check is a user is disabled before logging in #782

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shiv-tyagi
Copy link
Contributor

As discussed in #640, this adds a property to the UserDB to mark a user enable/disabled. Before creating an authentication session in pam, we check if the user exists in the cache and is disabled.

@shiv-tyagi shiv-tyagi requested a review from a team as a code owner February 7, 2025 16:14
@shiv-tyagi
Copy link
Contributor Author

@adombeck Does this look good?

I see that the tests are failing on main branch as well. So I am hoping that it is not me.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (36511cd) to head (fed3921).
Report is 323 commits behind head on main.

Files with missing lines Patch % Lines
internal/services/pam/pam.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
- Coverage   83.43%   83.16%   -0.28%     
==========================================
  Files          83       96      +13     
  Lines        8689     9646     +957     
  Branches       74       74              
==========================================
+ Hits         7250     8022     +772     
- Misses       1111     1243     +132     
- Partials      328      381      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants