fix: github release install silently fails if no urls found #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copies the fix from ublue-os/main#571 to ensure that the github release install script fails properly when nothing matches the filter. The bug fixed by this also relates to #214 since that kind of bug report will be caught by build failures in the future, thanks to this fix.
dosubot
bot
added
the
size:S
tulilirockz
approved these changes
Nov 17, 2024
m2Giles
approved these changes
Nov 17, 2024
castrojo
approved these changes
Nov 19, 2024
johnmmcgee
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the fix from ublue-os/main#571 to ensure that the github release install script fails properly when nothing matches the filter.
The bug fixed by this also relates to #214 since that kind of bug report will be caught by build failures in the future, thanks to this fix.
Thanks to @bcook254 for the solution in the ublue-os/main#571 PR.