-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): split build workflows by fedora version #525
Conversation
This will allow us to see if a specific version of Fedora is working or not, plus allow rebuilding only a specific version.
This won't actually auto-merge, since I've changed the builds to run version specific "Check all NN builds successful" jobs instead of the single "Check all builds successful". Once we get approvals, i'm happy to merge, or someone else can. |
Can this be used to remove a lot of the version-conditional logic in the reusable part by moving it into the version-specific files? |
That's a great idea, but unfortunately, with how inheritance works in this instance, that's easier said than done and could lead to a bunch of redundant code |
As @EyeCantCU, I don't think it would help much in this case, and would probably cause other code duplication. One thing I did contemplate moving, the conditionals for latest, stable and gts tagging... However, i chose to move them into the tag generation step (the only place they are used) and keep it there instead of passing in as inputs, because this keeps all the logic for it together, making it easier to read the whole context in one place. |
This will allow us to see if a specific version of Fedora is building or not, plus allow rebuilding only a specific version.
Extra bonus: this will let us adjust merge checks to require success of a subset of versions, eg
"Check all 38 builds successful" and "Check all 39 builds successful" but not 40.
This is nice for pre-release builds like what we have now.