Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): split build workflows by fedora version #525

Merged
merged 13 commits into from
Mar 24, 2024

Conversation

bsherman
Copy link
Contributor

@bsherman bsherman commented Mar 24, 2024

This will allow us to see if a specific version of Fedora is building or not, plus allow rebuilding only a specific version.

Extra bonus: this will let us adjust merge checks to require success of a subset of versions, eg
"Check all 38 builds successful" and "Check all 39 builds successful" but not 40.

This is nice for pre-release builds like what we have now.

@bsherman bsherman self-assigned this Mar 24, 2024
@bsherman bsherman marked this pull request as ready for review March 24, 2024 04:18
@bsherman bsherman requested a review from castrojo as a code owner March 24, 2024 04:18
@bsherman bsherman requested a review from a team March 24, 2024 04:20
@bsherman bsherman enabled auto-merge March 24, 2024 04:26
@bsherman bsherman disabled auto-merge March 24, 2024 04:26
@bsherman
Copy link
Contributor Author

This won't actually auto-merge, since I've changed the builds to run version specific "Check all NN builds successful" jobs instead of the single "Check all builds successful".

Once we get approvals, i'm happy to merge, or someone else can.

@dylanmtaylor
Copy link
Contributor

Can this be used to remove a lot of the version-conditional logic in the reusable part by moving it into the version-specific files?

@EyeCantCU
Copy link
Member

Can this be used to remove a lot of the version-conditional logic in the reusable part by moving it into the version-specific files?

That's a great idea, but unfortunately, with how inheritance works in this instance, that's easier said than done and could lead to a bunch of redundant code

@bsherman
Copy link
Contributor Author

Can this be used to remove a lot of the version-conditional logic in the reusable part by moving it into the version-specific files?

As @EyeCantCU, I don't think it would help much in this case, and would probably cause other code duplication.

One thing I did contemplate moving, the conditionals for latest, stable and gts tagging... However, i chose to move them into the tag generation step (the only place they are used) and keep it there instead of passing in as inputs, because this keeps all the logic for it together, making it easier to read the whole context in one place.

.github/workflows/reusable-build.yml Outdated Show resolved Hide resolved
@bsherman bsherman merged commit 143259d into main Mar 24, 2024
33 checks passed
@bsherman bsherman deleted the split-workflow-releases branch March 24, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants