feat: improve toggle-nvidia just command #245
Conversation
RoyalOughtness
force-pushed
the
main
branch
3 times, most recently
from
cb05841 to
b6239bd
Compare
HikariKnight
dismissed
their stale review
upon request as further changes has been noticed to be needed
Head branch was pushed to by a user without write access
build/ublue-os-just/40-nvidia.just
Outdated
| echo "Proprietary nvidia drivers are already enabled." | ||
| exit 0 | ||
| else | ||
| NEW_IMAGE=${CURRENT_IMAGE/-main/-nvidia} |
There was a problem hiding this comment.
this will not work on bluefin and bazzite since we do not have -main images there and future downstreams might not have it either
There was a problem hiding this comment.
@HikariKnight true, I'm open to suggestions here.
There was a problem hiding this comment.
@qoijjj dont know a good way to do this other than split the toggle-nvidia part into i guess 41-nvk.just or something and have downstream replace/adjust that file as needed.
that way we dont need to maintain a list of all base images for the check.
There was a problem hiding this comment.
@HikariKnight it doesn't really need to be a separate file. downstream images can just sed to replace NEW_IMAGE=${CURRENT_IMAGE/-nvidia/-main} with something else.
|
closing as needs further thinking |
#223