generated from ubiquity/ts-template
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an approval/funding UI #30
Closed
Closed
Changes from 4 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
bc37549
feat: rollback to template
zugdev 6719d29
chore: install dependencies
zugdev dc3aaaa
feat: base UI
zugdev 68e1715
feat: add network button
zugdev a220ca3
feat: add chains
zugdev f6a4e17
chore: format
zugdev 4571b5e
feat: basic styiling and form
zugdev 287505d
feat: add current allowance
zugdev a3caa79
feat: add neon border
zugdev 9634f81
feat: add token-selector and change expected allowance
zugdev edd0772
feat: fix token selector
zugdev 3befb07
feat: update dropdown tokens based on network
zugdev 03b9dcf
feat: add erc20 abi
zugdev 6fd952e
feat: rollback to current allowance
zugdev 9d1ffb8
feat: add permit2 address table
zugdev 19f3bbf
feat: add web3 integration
zugdev 5b93446
feat: initially disabled
zugdev 5f48675
feat: better error modal
zugdev 18adb4e
feat: all providers
zugdev 1337208
chore: pull alchemy key from secrets on build
zugdev 3c77a03
chore: yarn
zugdev 6478209
feat: make ALCHEMY_KEY optional
zugdev 4605da3
feat: enable anvil in localhost
zugdev e2149ad
chore: prettier
zugdev 89b0f04
feat: batch update
zugdev ba36a2c
feat: responsivity
zugdev 6bec149
chore: fix eslint version
zugdev 1f81afa
Merge branch 'development' of https://github.com/zugdev/onboard.ubq.f…
zugdev 8ea7037
chore: unlog
zugdev 7878d48
feat: fix signer
zugdev fa44c95
feat: loading while minting tx
zugdev f421786
feat: capitalize
zugdev c526d60
feat: get rid of chainId
zugdev b5c844a
feat: remove button setup
zugdev f801b95
feat: better naming
zugdev 3ffcf15
feat: add reference for zksync permit2 address
zugdev bded1b3
feat: use actions/create-github-app-token
zugdev 8f8fa38
feat: getAllowance on address only
zugdev c22af00
feat: add success modal
zugdev c0ca66d
feat: success pop up
zugdev 228f7d1
chore: fix jest
zugdev 834b8dd
feat: add explorers map
zugdev 1bd7ca8
feat: render success in revoke
zugdev 8105aab
feat: add tx linkback in success
zugdev 9299ea3
feat: remove alchemy from deploy
zugdev 23f3344
chore: fix knip
zugdev f04f3d1
chore: typo
zugdev 656e862
chore: missing div
zugdev 58edb53
Merge branch 'development' of github.com:zugdev/onboard.ubq.fi into d…
zugdev c906697
feat: const
zugdev 78fb771
chore: delete outdated
zugdev b525724
feat: feedback on erc20 fail
zugdev 326dbc2
chore: cspell
zugdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugdev marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now every time I click out of the amount input, the buttons get disabled until allowance is fetched and it's a weird UX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but thats what you meant by checking if its an erc20 token, should I add a spinner to indicate loading perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you will do the check when approve button is clicked and then it would show the error modal.