Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgraded dependency #89

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ramisback
Copy link

@ramisback ramisback commented Sep 26, 2024

There were vulernabilities in older dependencies so I have upgraded it

(GO-2020-0036)
(GO-2021-0061)
(GO-2022-0956)

@dgoldstein0
Copy link
Contributor

have you run the tests? https://github.com/ua-parser/uap-go?tab=readme-ov-file#testing unfortunately these aren't automated yet.

Also should mention, I took a look at the mentioned vulnerabilities. Practically they aren't interesting for this package - they are all about DOS against the yaml parser, but we don't parse user-supplied yaml. I think we actually just parse the uap-core yaml at build time. That said upgrading is probably a good idea so happy to accept the upgrades, provided the tests pass.

go.mod Outdated
@@ -1,6 +1,8 @@
module github.com/ua-parser/uap-go

go 1.23.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the policy regarding Go version support?

I guess we don't want to force everyone to use the latest Go version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the go directive in go.mod to specify a lower, stable Go version. This change is backward-compatible, as go.mod ensures dependencies are tied to specific commits. However, to enhance backward compatibility and provide a clearer upgrade path, we should consider implementing semantic versioning for the library

@pior
Copy link

pior commented Jan 27, 2025

have you run the tests? https://github.com/ua-parser/uap-go?tab=readme-ov-file#testing unfortunately these aren't automated yet.

Would you accept a PR to setup test in CI using Github Actions?

@dgoldstein0
Copy link
Contributor

have you run the tests? https://github.com/ua-parser/uap-go?tab=readme-ov-file#testing unfortunately these aren't automated yet.

Would you accept a PR to setup test in CI using Github Actions?

sure, please send one!

@ramisback
Copy link
Author

ramisback commented Jan 31, 2025

have you run the tests? https://github.com/ua-parser/uap-go?tab=readme-ov-file#testing unfortunately these aren't automated yet.

Also should mention, I took a look at the mentioned vulnerabilities. Practically they aren't interesting for this package - they are all about DOS against the yaml parser, but we don't parse user-supplied yaml. I think we actually just parse the uap-core yaml at build time. That said upgrading is probably a good idea so happy to accept the upgrades, provided the tests pass.

Yes, all tests are passing, I have also replaced deprecated ioutil with os package
It can be seen here reference

Copy link

@pior pior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.22.11 is the last 1.22 release 👍
Maintaining the two last Go versions looks good to me 👍

Changes look good as well.

(I'm not a maintainer of this package, we just use this lib)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants