Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: replace type of ext by specific string #48

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

haecheonlee
Copy link
Contributor

@haecheonlee haecheonlee commented Apr 28, 2024

It looks better to have specific string instead of general string for the variable, ext. As well, I removed the duplicate ext logic inside the function, createFile, and replaced it by the parameter.

@The-Code-Monkey
Copy link
Contributor

@haecheonlee can change the string of .tsx | .astro into a type so it can be used in multiple places rather then retyping stuff all over the place.

@haecheonlee
Copy link
Contributor Author

haecheonlee commented Apr 28, 2024

@The-Code-Monkey Do you have suggestion about how to manage types? I don't see any file to manage types only.

I created a type folder, and added a new type, Extension.

@haecheonlee haecheonlee force-pushed the enh/set-limited-type-to-ext branch from f117948 to a750a6b Compare April 29, 2024 01:59
@typicode
Copy link
Owner

Thanks!

@typicode typicode merged commit 0dcd857 into typicode:main Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants