Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nscplugin, sbt-scala-native, ... to 0.4.16 #112

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

📦 Updates

from 0.4.15 to 0.4.16

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number

The following files still refer to the old version number (0.4.15).
You might want to review and update them manually.

docs/index.md
tests/shared/src/test/scala/org/typelevel/toolkit/ScalaCliProcess.scala
⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-native" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-native" }
}]
labels: library-update, early-semver-minor, semver-spec-patch, old-version-remains, commit-count:1

@TonioGela
Copy link
Member

I'll say we should wait for:

  • All the downstream libs to publish
  • scala-cli releasing a version with 0.4.16 as default

@armanbilge
Copy link
Member

armanbilge commented Oct 14, 2023

All the downstream libs to publish

Why wait for this? It's not necessary, and if you really want to wait for all of them it's a lot of libs (think dependencies e.g. scalacheck, scodec, etc. etc.)

@TonioGela
Copy link
Member

All the downstream libs to publish

Why wait for this? It's not necessary, and if you really want to wait for all of them it's a lot of libs (think dependencies e.g. scalacheck, scodec, etc. etc.)

Yep, you're right, backward compatibility exists for a reason after all.
I was concerned about the opposite in fact: the moment the first library updates to 0.4.16 we are forced to update too.

@armanbilge armanbilge closed this Oct 25, 2023
@armanbilge armanbilge reopened this Oct 25, 2023
@TonioGela
Copy link
Member

@armanbilge the last fs2-io upgrade is making the CI failing due to Scala Native 0.4.16.
What's the best thing to do in your opinion? We can wait for scala-cli to update to 0.4.16 as a default version and keep every PR blocked until then?

@TonioGela
Copy link
Member

Ok, we've updated to cli 1.0.6 and it seems that the default version is now 0.4.16 for native. I'll remove the --nativeVersion flag from the tests, so that we can test PRs against the defaults (at least for the moment).

@mergify mergify bot added the tests label Nov 14, 2023
@armanbilge armanbilge merged commit 1d85da4 into main Nov 14, 2023
@armanbilge armanbilge deleted the update/nscplugin-0.4.16 branch November 14, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants