Fix retrying code in doPureApply. #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, 1. that binary compatibility check is really cool, but 2. how did this change break it? 😢 |
|
I think we should update mima to latest version (0.1.14). Mima 0.1.9 does not support Scala 2.12 and there are some bugs. |
This commit fixes a bug pointed out by @alexarchambault. When constructing an `A => B` value from `Cogen[A]` and `Gen[B]`, we need to be able to reliably generate a `B` value given a `Seed`. The `doPureApply` method was given the ability to retry -- but unfortunately, it used the same result value (with the same seed) instead of trying a new one, defeating the retry code. This commit fixes that problem. It adds tests to ensure that filtered generators that can also produce real values can be used with Gen.function1. (If a generator can never produce values it will still be a problem.) Fixes typelevel#300.
sellout
force-pushed
the
fix-retry-in-function-gen
branch
from
a0e9dfc to
ab40859
Compare
|
Rebased and looks good. Thanks. |
|
@rickynils Thanks – any chance of a 1.13.6 release with this in it? It’ll allow us to get off a 1.14 SNAPSHOT that makes dealing with conflicting dependencies a pain. |
|
@rickynils could we please release 1.13.6 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Backport of #301.)
This commit fixes a bug pointed out by @alexarchambault. When
constructing an
A => Bvalue fromCogen[A]andGen[B], we needto be able to reliably generate a
Bvalue given aSeed. ThedoPureApplymethod was given the ability to retry -- butunfortunately, it used the same result value (with the same seed)
instead of trying a new one, defeating the retry code.
This commit fixes that problem. It adds tests to ensure that filtered
generators that can also produce real values can be used with
Gen.function1. (If a generator can never produce values it will still
be a problem.)
Fixes #300.