Introduce PollResult, PollingSystem#processReadyEvents
#4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
requested changes
Jan 7, 2025
core/jvm-native/src/main/scala/cats/effect/unsafe/PollingSystem.scala
Outdated
Show resolved
Hide resolved
| @@ -480,6 +481,9 @@ private[effect] final class WorkerThread[P <: AnyRef]( | |||
| if (parked.getAndSet(false)) { | |||
| pool.doneSleeping() | |||
| } | |||
| if (polled) { // TODO, if no tasks scheduled and no timers could fastpath back to park? | |||
| val _ = system.processReadyEvents(_poller) | |||
core/native/src/main/scala/cats/effect/unsafe/KqueueSystem.scala
Outdated
Show resolved
Hide resolved
|
Btw this is a much better name than what I came up with |
armanbilge
changed the title
PollingSystem#processReadyEventsPollResult, PollingSystem#processReadyEvents`
armanbilge
changed the title
PollResult, PollingSystem#processReadyEvents`PollResult, PollingSystem#processReadyEvents
djspiewak
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4229.
PollingSystem#pollis now split intopollandprocessReadyEvents, wherepolldoes the blocking syscall (and nothing more) andprocessReadyEventshandles rescheduling of fibers on the runtime. This enables theWorkerThreadto unpark afterpolland beforeprocessReadyEvents, so that it is in the appropriate state for receiving new work on its local queue.