-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance error printing and query source span availability #391
Merged
flyingsilverfin
merged 13 commits into
typedb:3.0
from
flyingsilverfin:annotated-query-ranges
Jan 30, 2025
Merged
Enhance error printing and query source span availability #391
flyingsilverfin
merged 13 commits into
typedb:3.0
from
flyingsilverfin:annotated-query-ranges
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
flyingsilverfin
force-pushed
the
annotated-query-ranges
branch
from
January 29, 2025 22:45
97610d0
to
3f1a0cc
Compare
flyingsilverfin
force-pushed
the
annotated-query-ranges
branch
from
January 29, 2025 23:36
024963d
to
2901ef6
Compare
flyingsilverfin
force-pushed
the
annotated-query-ranges
branch
from
January 30, 2025 18:30
ef6daf7
to
103a11b
Compare
flyingsilverfin
force-pushed
the
annotated-query-ranges
branch
from
January 30, 2025 18:37
103a11b
to
a44d3fe
Compare
flyingsilverfin
force-pushed
the
annotated-query-ranges
branch
from
January 30, 2025 18:50
4a9d745
to
b0b7f2e
Compare
flyingsilverfin
force-pushed
the
annotated-query-ranges
branch
from
January 30, 2025 21:06
f0e1dd3
to
44b3eb5
Compare
flyingsilverfin
changed the title
Make a reusuable query string annotation function
Enhance error printing and query source span availability
Jan 30, 2025
flyingsilverfin
commented
Jan 30, 2025
Comment on lines
+84
to
+86
"{SYNTAX_ANNOTATED_INDICATOR_LINE}{line_string}\n{}{SYNTAX_ANNOTATED_INDICATOR_COL}", | ||
" ".repeat(SYNTAX_ANNOTATED_INDENT + col) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We add both the line indicator, and a following like with an ^
column indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage and product changes
We improve the error messages to show a
^
column indicator along with-->
line indicator:We also expose more information about where in the original query spans which sourced various internal data structures.
Implementation
Span
s throughout TypeQL data structures