Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix383 #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix383 #1

wants to merge 3 commits into from

Conversation

fgrunewald
Copy link

@tylerjereddy

I've fixed a bug in CGSmiles that was causing the issue with the atomnames. It is still under review gruenewald-lab/CGsmiles#33 but I made sure it works this time.

Furthermore, I noticed that your CGSmiles string did not include terminal residues. That was a mistake on my side. When we changed the CGSmiles parser we did not fully update gen_ff. In a nutshell, you should always define terminal residues, which in this case would be hydrogen atoms. See repro.py.

Finally, I've added a python script that computes single-point energies between two itp files. That is the best way to check that the itp produced with polyply matches the original one. If all goes well, there should only be minor differences in Coulomb energies because we slightly change the charges. Sometimes the LJSR energies are a little different, which as far as I can tell has to do with GROMACS run initialization not being the same. N.B. the script compare.py requires a bunch of python libraries, so make sure to install the dependencies.

With the ff file you produced you can already get started with the larger polymer. For future reference, I would probably use some CH3 groups as terminal residues to avoid polarization across residues.

@tylerjereddy
Copy link
Owner

@fgrunewald excellent, thank you, making some progress with this now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants