Add release toolkit to this repository #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiamoe
reviewed
Jun 7, 2024
| # This file is a dictionary used by the [link-dependencies](https://github.com/newrelic/release-toolkit/tree/main/link-dependencies) action. | ||
| # Notice that the implementation uses dep.To.ToString that removes the leading v if present. | ||
| dictionary: | ||
| # TODO: Unable to link dependency for Power DNS because it uses a weird changelog URL scheme: |
There was a problem hiding this comment.
This might be worth raising upstream. The code is already using templates, and is already importing the semver package, so it should be a matter of a couple lines of code to expose the major and minor functions to the template, such that you can do something like:
https://doc.powerdns.com/authoritative/changelog/{{.To | major}}.{{.To | minor}}.html#change-{{.To}}
Hopefully we can find a rt maintainer that can listen to this request 🤞🏻
There was a problem hiding this comment.
I cannot open an issue from my personal laptop because I am redirected to my company's Okta. I know release-toolkit is open source but 🤷
I'll open a ticket tomorrow morning.
There was a problem hiding this comment.
kilokang
force-pushed
the
kang-makes/feat/release-toolkit
branch
from
b63693a to
f524632
Compare
kilokang
force-pushed
the
kang-makes/feat/release-toolkit
branch
from
f0c6170 to
12e3afe
Compare
kilokang
force-pushed
the
kang-makes/feat/release-toolkit
branch
from
1da289d to
7bf5a77
Compare
nadiamoe
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR I wish to have change logs automated so I can enable renovatebot and have readable Changelogs for this chart.
Software like Power DNS is still being updated and released and is not being update on this chart.
I would also have a PR from renovate each time that
external-dnsrelease a version so I can investigate if there is a feature that worth be added to this chart.