Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc supervisor-barge-coach fixes, test fixes #704

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Misc supervisor-barge-coach fixes, test fixes #704

merged 2 commits into from
Jan 11, 2025

Conversation

dremin
Copy link
Contributor

@dremin dremin commented Jan 9, 2025

Summary

Found these while porting the code to the plugin library.

Misc supervisor-barge-coach fixes:

  • Fix coach then barge not working (actual behavior stayed as coaching due to serverless not setting the flag)
  • Add missing localization string for Listen
  • Fix unused local storage variable being read after refresh

Misc test fixes:

  • Fix Paste icons breaking jest
  • Fix useFlexSelector with jest

Checklist

  • Tested changes end to end
  • Requested one or more reviewers

- Fix coach then barge not working
- Fix missing localization string
- Fix unused local storage variable
- Fix Paste icons breaking jest
- Fix useFlexSelector with jest
Copy link

github-actions bot commented Jan 9, 2025

0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files.
✅ No issues found!

Copy link

@trogers-twilio trogers-twilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for catching these bug fixes.

@dremin dremin merged commit ca40b9d into main Jan 11, 2025
4 checks passed
@dremin dremin deleted the misc-sbc-fixes branch January 11, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants