Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/enhanced queue filter array support #703

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/enhanced queue filter array support #703

wants to merge 2 commits into from
+10 −9

Conversation

SeanHolden
Copy link

Summary

Provide a summary of the change

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

@SeanHolden SeanHolden mentioned this pull request Jan 8, 2025
Open
dremin
dremin requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@dremin dremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @SeanHolden! A couple issues I noticed:

  1. The change removes the global queue filter inadvertently, it needs to be added back (ideally with the same enhancement!)
  2. The type definitions need to be updated. For the worker attributes, this is in types/task-router/Worker.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dremin dremin dremin requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeanHolden @dremin