Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom-transfer-directory performance with many items #700

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

dremin
Copy link
Contributor

@dremin dremin commented Dec 20, 2024

Summary

  • Limit rendered items to improve performance
  • Change custom components to functions that are only rendered if the item will be rendered
  • Fix loading workers above 1000
  • Remove realtime queue updates, add update button

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

Copy link

0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files.
✅ No issues found!

- Prevent rendering buttons unless hovered
- Disable real-time queue data updates to prevent annoying UX where the item changes while the user attempts to interact
- Add 'update list' button that can be used to manually refresh queue data
- Bump default max items to 200, same as Flex UI default
- Fetch all workers up to 15000, which is the default max worker limit
Copy link

@trogers-twilio trogers-twilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for making the suggested config change, and for all the performance enhancements.

@dremin dremin merged commit 9c6caf1 into main Jan 17, 2025
5 checks passed
@dremin dremin deleted the custom-directory-performance branch January 17, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants