Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pause-recording robustness #562

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Improve pause-recording robustness #562

merged 2 commits into from
Jun 7, 2024

Conversation

dremin
Copy link
Contributor

@dremin dremin commented May 31, 2024

Summary

  • Handle multiple simultaneous recordings (dual-channel and conference recordings at the same time)
  • Handle missing recording (instead of showing a failure message, such as when recording is completely disabled, or excluded by rule)
  • Improve logs

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

dremin added 2 commits May 31, 2024 17:57
@dremin
Improve pause-recording robustness
5328f59 
Handle multiple simultaneous recordings
Handle missing recording
Improve logs
@dremin
Update docs
aa07cf3
@github-actions GitHub Actions
Copy link

0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files.
✅ No issues found!

trogers-twilio
trogers-twilio approved these changes Jun 7, 2024
View reviewed changes
Copy link

@trogers-twilio trogers-twilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Great idea to support pausing both conference recording and call recording if both happen to be enabled.

@dremin dremin merged commit 0a4afb4 into main Jun 7, 2024
5 checks passed
@dremin dremin deleted the pause-recording-robustness branch June 7, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trogers-twilio trogers-twilio trogers-twilio approved these changes

@Romanti-Ezer Romanti-Ezer Awaiting requested review from Romanti-Ezer

@aestellwag aestellwag Awaiting requested review from aestellwag

@dahamilton-twilio dahamilton-twilio Awaiting requested review from dahamilton-twilio

@swillcox-twilio swillcox-twilio Awaiting requested review from swillcox-twilio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dremin @trogers-twilio