Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SE-22] Run and use Flex Insights proxy #550

Merged
merged 2 commits into from
Apr 24, 2024
Merged

[SE-22] Run and use Flex Insights proxy #550

merged 2 commits into from
Apr 24, 2024

Conversation

dremin
Copy link
Contributor

@dremin dremin commented Apr 24, 2024

Summary

This change fixes a few problems when running locally:

  • Fixes the error banner regarding Insights being unable to load
  • Allows accessing Insights from the local plugin so that testing can be performed. For example, when customizing messaging components, it can be useful to test them when opening a chat from Insights, as there is no task object.

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

@github-actions GitHub Actions
Copy link

0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files.
✅ No issues found!

Romanti-Ezer
Romanti-Ezer approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@Romanti-Ezer Romanti-Ezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Great addition Sam 🎉

image

@dremin dremin merged commit 2706c91 into main Apr 24, 2024
5 checks passed
@dremin dremin deleted the insights-proxy branch April 24, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Romanti-Ezer Romanti-Ezer Romanti-Ezer approved these changes

@trogers-twilio trogers-twilio Awaiting requested review from trogers-twilio

@aestellwag aestellwag Awaiting requested review from aestellwag

@dahamilton-twilio dahamilton-twilio Awaiting requested review from dahamilton-twilio

@swillcox-twilio swillcox-twilio Awaiting requested review from swillcox-twilio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dremin @Romanti-Ezer