Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Post call survey #512

Conversation

chaosloth
Copy link
Contributor

@chaosloth chaosloth commented Mar 15, 2024

Summary

Adds post call survey UI designer, rules editor and dynamic IVR

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

@chaosloth
Copy link
Contributor Author

@dremin @JasonLearmouth @jared-hunter Hey fellas, would you mind making a review of the above

@dremin
Copy link
Contributor

dremin commented Mar 15, 2024

202 ESLint error(s) and 6 ESLint warning(s) found in pull request changed files.

@chaosloth Could you please resolve the eslint issues? You can see them locally using npm run lint, or have it auto-fix as much as possible using npm run lint:fix.

The checks will still fail because this is coming from a fork, but the linter catches a lot of things I would bring up anyway in review :)

@dremin
Copy link
Contributor

dremin commented Mar 15, 2024

@chaosloth I've been playing with this and it's very nice! Good work! 🎉

However, I'm concerned about the scalability of using Sync for end-customer-facing solutions like this. Within the context of Flex UI itself Sync is usually fine, but once you add that to something that potentially runs multiple times for every customer call, the limits creep up quickly. I would be more comfortable with this if the configuration was stored in serverless, as in schedule-manager or inbound-sip-router.

Another thing I noticed is that this feature is enabled by default, but it requires manual configuration to be usable. The Terraform package needs to be updated to deploy the necessary TR workflow, and the mappings.json configuration should be updated to auto-populate the SID within .env.example based on workflow name.

I also think a "how it works" section for the docs would be helpful so that new users can understand it better. It should explain how the call gets routed to the dynamic IVR, and how the attributes are populated & can be used for Flex Insights consumption.

@dremin
Copy link
Contributor

dremin commented Dec 11, 2024

Closing this PR as it has been stalled for some time. Feel free to open a new PR once the changes requested are ready!

@dremin dremin closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants