-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Post call survey #512
FEATURE: Post call survey #512
Conversation
Merge main into PCR
Merge pull request #2 from twilio-se-anz/main
…nal-services#492. Add debugging and correct logic
…nal-services#492. Add debugging and correct logic
Merge upstream to ANZ SE repo
@dremin @JasonLearmouth @jared-hunter Hey fellas, would you mind making a review of the above |
@chaosloth Could you please resolve the eslint issues? You can see them locally using The checks will still fail because this is coming from a fork, but the linter catches a lot of things I would bring up anyway in review :) |
@chaosloth I've been playing with this and it's very nice! Good work! 🎉 However, I'm concerned about the scalability of using Sync for end-customer-facing solutions like this. Within the context of Flex UI itself Sync is usually fine, but once you add that to something that potentially runs multiple times for every customer call, the limits creep up quickly. I would be more comfortable with this if the configuration was stored in serverless, as in schedule-manager or inbound-sip-router. Another thing I noticed is that this feature is enabled by default, but it requires manual configuration to be usable. The Terraform package needs to be updated to deploy the necessary TR workflow, and the I also think a "how it works" section for the docs would be helpful so that new users can understand it better. It should explain how the call gets routed to the dynamic IVR, and how the attributes are populated & can be used for Flex Insights consumption. |
Closing this PR as it has been stalled for some time. Feel free to open a new PR once the changes requested are ready! |
Summary
Adds post call survey UI designer, rules editor and dynamic IVR
Checklist