Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor custom directory components for reusability, override worker directory #430

Merged
merged 9 commits into from
Nov 17, 2023

Conversation

dremin
Copy link
Contributor

@dremin dremin commented Nov 9, 2023

Summary

Now if someone wants to add their own tab, it is much easier:

  • There is a common DirectoryTab component that includes all of the layout and search logic.
  • There is a common DirectoryItem component for rows in DirectoryTab
  • Now to add a new tab, just pass an array of DirectoryEntry objects, and a transfer function, to DirectoryTab

Added a custom worker directory tab to complement the queue tab. Now the worker tab can filter unavailable agents, and has the correct icons per media type.

Checklist

  • Tested changes end to end
  • Requested one or more reviewers

@dremin dremin added the ready-for-review PR is ready to be review label Nov 9, 2023
@dremin dremin requested a review from jared-hunter November 9, 2023 00:14
Copy link

github-actions bot commented Nov 9, 2023

0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files.
0 ESLint error(s) and 0 ESLint warning(s) found in files outside of the pull request.

✅ No issues found!

@dremin dremin changed the title Refactor custom directory items as one component Refactor custom directory components for reusability Nov 9, 2023
@dremin dremin changed the title Refactor custom directory components for reusability Refactor custom directory components for reusability, override worker directory Nov 13, 2023
Copy link
Contributor

@jared-hunter jared-hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, i love the refactor - some minor updates to tackle plus an optional item on the no items label

I think we want to update the documentation too, to conform to the broader standard but we can do that as part of a separate effort.

Copy link
Contributor

@jared-hunter jared-hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@dremin dremin merged commit dbeba42 into main Nov 17, 2023
5 checks passed
@dremin dremin deleted the custom-directory-refactor branch November 17, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review PR is ready to be review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants