-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor custom directory components for reusability, override worker directory #430
Conversation
0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files. ✅ No issues found! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, i love the refactor - some minor updates to tackle plus an optional item on the no items label
I think we want to update the documentation too, to conform to the broader standard but we can do that as part of a separate effort.
...template-v2/src/feature-library/custom-transfer-directory/custom-components/DirectoryTab.tsx
Outdated
Show resolved
Hide resolved
...x-ts-template-v2/src/feature-library/custom-transfer-directory/types/ServiceConfiguration.ts
Show resolved
Hide resolved
plugin-flex-ts-template-v2/src/feature-library/custom-transfer-directory/config.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Summary
Now if someone wants to add their own tab, it is much easier:
Added a custom worker directory tab to complement the queue tab. Now the worker tab can filter unavailable agents, and has the correct icons per media type.
Checklist