Add support for @upper_case @lower_case captures #838
+117
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctdunc
commented
Jan 17, 2025
| lower_case_level += 1; | ||
| *atom = Atom::Empty; | ||
| if upper_case_level > 0 { | ||
| panic!("Cannot use @upper_case inside of a node captured by @lower_case!"); |
There was a problem hiding this comment.
This is probably not ideal, but I wasn't sure what the preferred way of handling such errors is. There may also be times where users want to capitalize all but a subset of a node, which this would need to be changed to support.
ctdunc
force-pushed
the
feature/capitalization
branch
from
bbbf44b to
5da7294
Compare
ctdunc
commented
Jan 17, 2025
topiary-core/src/atom_collection.rs
Outdated
| how_capitalize: HowCapitalize::UpperCase, | ||
| } | ||
| } else if lower_case_level > 0 { | ||
| *atom = Atom::Leaf { |
There was a problem hiding this comment.
these derefs feel wrong, but I'm not really a Rust expert, so I am not sure whether these are copying. I will learn from whatever feedback you can provide on this
| } => { | ||
| // TODO don't be stupid with derefs | ||
| *atom = Atom::Leaf { | ||
| content: (*content).to_string(), |
There was a problem hiding this comment.
the derefs here feel bad. I'm sure there's a rustier way to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for @upper_case @lower_case captures.
Issue: #836
Description
This adds really basic support for the feature discussed in the linked issue.
I tested it with my SQL capture, and it works, but I don't know if adding SQL as a language is in scope for this PR and there are a lot of other issues with my query (it's still kinda ugly).
Checklist
Checklist before merging: