Use tree-sitter-loader to build grammars
#830
Open
+758
−427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Xophmeister
requested review from
nbacquey and
yannham
and removed request for
nbacquey
Also remove direct dependency on `cc` (now a transitive dependency)
Xophmeister
force-pushed
the
chris/grammar-build
branch
from
7b3ed84 to
eb43c2c
Compare
|
Hmm... Well this is quite annoying. This builds fine and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to
tree-sitter-loaderto build grammarsResolves #821
Resolves #829
Description
Do a light clone of the grammar repo (
--filter=blob:none).Use
tree-sitter-loader::Loader::compile_parser_at_pathto build grammars dynamically, rather than curating our own build pipeline. This should give us cross-platform support.Checklist
Checklist before merging: