-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconnect #484
Merged
Merged
Reconnect #484
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
12cc710
Adding support for ice_servers message
daonb ea5264c
Fixing handling of ice_servers message
daonb bca985c
Fixing zoom
daonb 5ca9727
Polishing
daonb 82b80df
Fixing direct pane navigation on the web
daonb fab7fcb
Polishing
daonb a5f6a6c
Adding a lost s
daonb cdbc68c
Polishing some more
daonb 11282fd
Improving messages
daonb 1548f90
Fixing webgl out of memory, fix #341
daonb 41f9f53
Polishing
daonb 7857292
Fixing late arriving answers handling
daonb 6d3e29e
Fixing peerbook reconnection failures
daonb 694939c
Fixing fit my screen for a single user
daonb f68522b
Improving pb error handling
daonb 8022d7e
Fixing a bug with ICE configuration
daonb 5678746
Setting window focus right
daonb c9c0e3d
Polishing
daonb b4f0e63
Improving reconnect & not for the last time
daonb 4a3eded
Fixing the gates' parent
daonb f02a376
Extending a timeout in a test
daonb ff0f273
Merge branch 'master' into reconnect
daonb 12f0ffb
Hiding TWR on pane tab & doubletap
daonb 405155b
Making the gates-container to a class
daonb 8368628
WIP
daonb 7bd394f
Fixing reconnect
daonb 02cd0f1
Polishing
daonb 15c403d
Killing the canary as it was more noise than signal
daonb 2cdcfad
Improving gate and shell recovery
daonb edeb707
Improving peerbook admin messages id & cleanuo
daonb 4a78fea
Adding timw to log messages
daonb ad69190
Simplifying pbConnect
daonb f1348ed
Adding isOpenish and file cleanup
daonb 4dd25b3
Removing redundent watchdog
daonb 9717846
Fixing first install
daonb adb1ae6
Polishing
daonb 6ac5d77
Fixing two small bugs
daonb 523f4a9
Opening the CDC when needed
daonb dd9dc26
Clearing penging message to prevent doubling
daonb df1d515
Ignoring signaling state when getting candidate
daonb 09221b2
Removing a log message
daonb 7034b3c
Removing another log line
daonb 4a972fd
Extending a timeout
daonb c437173
Improving unit tests stability
daonb 4a34f8e
Linting
daonb 0aa3fbf
Polishing
daonb 1dba143
Cleaning up
daonb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
We need to replace hammerjs package as it's not maintained anymore. | ||
What package should we use? We currently use hammerjs for tap, pan, cut , press and pinch events. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
We need to write a js function that will receive a scale factor and a container element that includes on or more WebGL canvases. the function should the container element and a ll the canvases. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix grammatical error and consider adding implementation criteria.
There is a grammatical error in the prompt. The corrected sentence should be: "The function should scale the container element and all the canvases." Additionally, consider adding criteria for the function's implementation, such as performance, compatibility, or specific scaling requirements.
Apply this diff to fix the grammatical error:
Committable suggestion
Tools
LanguageTool