-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend support command to dump log #446 #450
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
cd8a138
Removing the login command, fixes #444
shech2 5d7a362
Removing login command , #444
shech2 c1804c9
Restoring to default
shech2 28ca86b
Extending support command to dump log - added email and log #446
shech2 b005f51
Fixing some typos and making the code prettier
shech2 3851f18
Adding another fix i missed
shech2 88047a6
Merge branch 'master' into Extend_support_command_to_dump_log
shech2 b18eb77
Updating aatp to match our previous changes (replaced login with subs…
shech2 8e3084b
Fixing a typo
shech2 05fbe88
Adding netlify settings for cache
shech2 fe6c606
Making email shorter and clearer and now its asking for email if its …
shech2 98a0102
Adding Better feedback
shech2 cd66ee6
Fixing a typo
shech2 bd04d08
Changing email to let
shech2 02f2939
Updating index.html to match other PR's
shech2 7767f78
Modifing netlify to match all htmls
shech2 15e91fd
Refactoring dumpLog()
shech2 abc0d84
Adding a finer menu for support including copy to clipboard and sendi…
shech2 8aa38f0
Fixing bugs
shech2 90ceaa3
Fixing issues
shech2 ab6fe69
Deleting module script
shech2 577b5df
Restored main.ts
shech2 a5088d5
Changing writeln to notify
shech2 20c22ed
Adding Cancel chosise and changed to switch case
shech2 da10a86
Adding capacitor FileSystem plugin
shech2 6c4fead
Adding premissions for android
shech2 32457d3
Changing supportCMD function to check if Platform is native or not
shech2 cac3390
Adding support tests
shech2 12a0780
Coderabbit suggestions
shech2 b0dd275
Fixing all rejects
shech2 4b8696c
Merge branch 'master' into Extend_support_command_to_dump_log
shech2 812ef5b
Fixing a space
shech2 28749d3
Added suggested change
shech2 7f11b9b
Fixing a typo in support cmd
shech2 744653c
Deleting get-docker
shech2 e322124
Adding the required changes
shech2 539142e
Fixing the structure
shech2 1586aab
Changing "" with ''
shech2 723610f
Applying suggestions
shech2 0c826fe
Applying suggestions
shech2 faa462c
Fixing new line reject
shech2 baa13a2
Fixed the issue
shech2 a85358e
Improving tests stability
daonb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
FROM redis:alpine | ||
RUN echo "appendonly no" >> /etc/redis.conf | ||
RUN echo 'appendonly no' > /etc/redis.conf | ||
RUN echo 'save ""' >> /etc/redis.conf | ||
CMD [ "redis-server", "/etc/redis.conf" ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -350,4 +350,36 @@ test.describe('peerbook administration', () => { | |
const twr = await getTWRBuffer(page) | ||
expect(twr).toMatch(/Logged in/) | ||
}) | ||
test('test the support command', async ({request}) => { | ||
await sleep(100) | ||
await page.keyboard.type('support') | ||
await page.keyboard.press('Enter') | ||
await sleep(100) | ||
let twr = await getTWRBuffer(page) | ||
expect(twr).toMatch(/address:$/) | ||
await page.keyboard.type('[email protected]') | ||
await page.keyboard.press('Enter') | ||
await sleep(100) | ||
await page.keyboard.press('ArrowDown') | ||
await page.evaluate(() => { terminal7.log('log line')}) | ||
await page.keyboard.press('Enter') | ||
await sleep(100) | ||
twr = await getTWRBuffer(page) | ||
expect(twr).toMatch(/issue:$/) | ||
await page.keyboard.type('test issue') | ||
await page.keyboard.press('Enter') | ||
|
||
let count = 0 | ||
let msg | ||
while (count < 2) { | ||
await sleep(100) | ||
const res = await request.get('http://smtp:8025/api/v2/messages') | ||
msg = await res.json() | ||
count = msg.count | ||
} | ||
expect(msg.count).toBe(2) | ||
const body = msg.items[0].Content.Body | ||
expect(body).toMatch(/test issue/) | ||
expect(body).toMatch(/log line/) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new test for the "support" command is well-structured and covers the expected behavior. However, consider adding assertions to verify that the email address (
[email protected]
) and the log line (log line
) are included in the email body sent by the support command to ensure the complete log dump is captured.Committable suggestion