Removing peerbook's websocket for full WebRTC #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding a firstMsg paramter to Peerbook.connect so it'll be sent before the pending messages
need to go back to application/sdp and fix restore
not that it helps. we need to optimize this, probably using the disconnect event to reconnect
✅ Deploy Preview for terminal7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
so it's more like the real env and tests stop failing
| @@ -267,14 +262,14 @@ export class PeerbookConnection { | |||
| terminal7.log("Got TBD as uid") | |||
| reject("Unregistered") | |||
| } else { | |||
| Purchases.logIn({ appUserID: uid }) | |||
| terminal7.run(() => Purchases.logIn({ appUserID: uid }), 10) | |||
| resolve() | |||
| } | |||
| }).catch(e => { | |||
| this.session = null | |||
| terminal7.log("Failed to get user id", e.toString()) | |||
| resolve() | |||
There was a problem hiding this comment.
Why does it do resolve in catch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.