Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): expose clear method #5438

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

jizai1125
Copy link
Contributor

closes #5423

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
naive-ui ❌ Failed (Inspect) Dec 18, 2023 11:01am

@@ -812,6 +812,7 @@ export default defineComponent({
inputElRef,
textareaElRef,
isCompositing: isComposingRef,
clear: handleClear,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To conform exposed type. It should be clear: () => handleClear(). Also, onClear shouldn't be called since it's an user reaction.

@07akioni 07akioni merged commit 17be8c4 into tusen-ai:main Dec 18, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

表单组件暴露clear方法
2 participants